Fixing the broken build by updating the Java Version.#114
Closed
BrenoFariasdaSilva wants to merge 8 commits intomauricioaniche:masterfrom
Closed
Fixing the broken build by updating the Java Version.#114BrenoFariasdaSilva wants to merge 8 commits intomauricioaniche:masterfrom
BrenoFariasdaSilva wants to merge 8 commits intomauricioaniche:masterfrom
Conversation
| # CK | ||
|
|
||
| [](https://travis-ci.org/mauricioaniche/ck) | ||
|  |
Owner
There was a problem hiding this comment.
We can't change that to your repository. Mine should be the official one.
|
|
||
| public class Runner { | ||
|
|
||
| public static Map<String,Integer> methodOccurrences = new HashMap<>(); |
Owner
There was a problem hiding this comment.
The Runner should ideally have no business logic at all. You should move this somewhere else.
Owner
|
Thanks, @BrenoFariasdaSilva, for the PR! I have some comments there. But most importantly, it'd be best if you split your PRs. For example, the introduction of a make file has nothing to do with the rest. The smaller the PR the easier it is for me to review and to rollback if needed. |
Contributor
Author
|
Thanks for the feedback @mauricioaniche! 'll make the necessary changes ASAP. A new PR was made. You can find it here PR 115. |
BrenoFariasdaSilva
force-pushed
the
master
branch
from
93a7294 to
2904516
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.