Update mavlink and add PARAM_ERROR #2698
Merged
+408
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
previously approved these changes
Oct 31, 2025
|
Pending: mavlink/mavlink#2373 |
julianoes
force-pushed
the
pr-param-error
branch
from
97ab62f to
f26f9e0
Compare
Currently the PARAM_EXT param_value field is broken due to a recent pymavlink change. Until that's fixed, we have to carry another patch.
This adds support for the new PARAM_ERROR message which makes the param protocol more robust in case things go wrong. Instead of waiting for a timeout, we actually get an error.
julianoes
force-pushed
the
pr-param-error
branch
from
f26f9e0 to
ae250bb
Compare
|
JonasVautherin
approved these changes
Nov 4, 2025
|
@julianoes Thanks very much! FYI I am tidying up the param xml in mavlink/mavlink#2365 - in particular to make it clear when index/id are returned in the PARAM_VALUE and PARAM_ERROR (I'll get you to look when fully agree this with Peter). Anyhow, the point is that there will be another error for "no parameters at all" returned by the request for all parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates mavlink including a patch containing ArduPilot/pymavlink#1143.
Then, we add PARAM_ERROR for better param error handling as added in mavlink/mavlink#2344.
Depends on mavlink/MAVSDK-Proto#384.
FYI @hamishwillee