Skip to content

Conversation

@patrickelectric
Copy link
Member

This properly converts strings from inside or outside serde.

@patrickelectric patrickelectric force-pushed the improve-serde-string-ser-deser branch 2 times, most recently from b9d2387 to 8e4e483 Compare October 8, 2025 14:27
@onur-ozkan
Copy link
Collaborator

Can you tell more about the problem/use-case? I don't know the context to review this properly.

@patrickelectric patrickelectric force-pushed the improve-serde-string-ser-deser branch from 8e4e483 to f41b15b Compare October 8, 2025 15:02
@patrickelectric patrickelectric force-pushed the improve-serde-string-ser-deser branch from f41b15b to 616ccc7 Compare October 8, 2025 15:08
@patrickelectric
Copy link
Member Author

Can you tell more about the problem/use-case? I don't know the context to review this properly.

When using serde, it is serializing and deserializing as a u8 array over a string, this PR fix that.

@onur-ozkan
Copy link
Collaborator

Can you tell more about the problem/use-case? I don't know the context to review this properly.

When using serde, it is serializing and deserializing as a u8 array over a string, this PR fix that.

Feels like related to #388?

@patrickelectric
Copy link
Member Author

#388 only changes the Rust interface not the serde serialization.

@onur-ozkan onur-ozkan merged commit 91a6317 into mavlink:master Oct 9, 2025
45 checks passed
@joaoantoniocardoso
Copy link
Collaborator

Feels like related to #388?

This PR defines the behavior we want around strings when serializing/deserializing into/from JSON. This work can, in the future, be rearranged with the PR, which focuses on the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants