-
Notifications
You must be signed in to change notification settings - Fork 96
Improve string serde serialization/deserialization #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve string serde serialization/deserialization #415
Conversation
b9d2387 to
8e4e483
Compare
|
Can you tell more about the problem/use-case? I don't know the context to review this properly. |
8e4e483 to
f41b15b
Compare
Signed-off-by: Patrick José Pereira <[email protected]>
…zation Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
f41b15b to
616ccc7
Compare
When using serde, it is serializing and deserializing as a u8 array over a string, this PR fix that. |
Feels like related to #388? |
|
#388 only changes the Rust interface not the serde serialization. |
This PR defines the behavior we want around strings when serializing/deserializing into/from JSON. This work can, in the future, be rearranged with the PR, which focuses on the API. |
This properly converts strings from inside or outside serde.