Fix CI: PTY echo timing normalization and workflow permissions #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PTY tests capturing interactive install prompt had flaky output due to
timing differences between local and CI environments. The user's input
character ('y' or 'n') would appear either before the prompt or at the
end of the prompt line depending on timing.
Added normalization in `normalize_output()` to:
- Remove echoed input character from end of prompt line
- Remove standalone input lines that appear before the prompt
This ensures consistent snapshots regardless of PTY echo timing.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
The claude-code-action requires `id-token: write` permission to fetch an OIDC token for GitHub authentication. Without this, the action fails with "Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable". 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
id-token: writepermission to claude-ci-fix workflowTest plan
🤖 Generated with Claude Code