-
Notifications
You must be signed in to change notification settings - Fork 40
fix: update snapshot for COLUMNS=500 terminal width #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d15938a to
620a1b2
Compare
Commit 53d6409 changed test COLUMNS from 150 to 500, but this snapshot wasn't updated. The snapshot metadata needs to reflect the new terminal width to match the actual test environment. The snapshot content (with ✗ symbol for working tree conflicts) is correct and unchanged. Fixes CI failure from run 20843503339.
620a1b2 to
f32d486
Compare
|
@claude merge main into this |
|
Claude finished @max-sixty's task in 48s —— View job Merging main into PR branch
SummarySuccessfully merged main into the PR branch. The merge was clean with no conflicts - it pulled in changes to The branch is now up to date with main and the changes have been pushed to origin. |
Co-authored-by: Maximilian Roos <[email protected]>
|
@claude why isn't CI running? |
|
Claude finished @max-sixty's task in 3m 49s —— View job Why CI Isn't RunningCI workflows are not triggered for commits authored by GitHub Apps (including the Claude bot). This is a GitHub Actions security feature to prevent infinite loops. What Happened
All commits on this branch are now authored by SolutionYou have two options: Option 1: Add a commit yourself (recommended) git checkout fix/ci-20843503339
git commit --allow-empty -m "chore: trigger CI"
git pushSince you're not a bot, this will trigger CI. Option 2: Close and reopen the PR Option 3: Manual workflow trigger Why This Limitation ExistsGitHub prevents bot commits from triggering workflows to avoid scenarios like:
|
Trigger CI workflows after bot merge commit. Co-authored-by: Maximilian Roos <[email protected]>
|
Claude finished @max-sixty's task in 2m 4s —— View job Investigating CI difference between PRs
The Key DifferencePR #485 had CI run because it was opened with the bot commit already in place. GitHub Actions triggers CI on the What Happened in Each PRPR #485 (CI ran ✓):
PR #486 (CI didn't run ✗):
Then you requested "merge main into this":
Why My Previous Explanation Was IncompleteI said "CI doesn't run for bot commits," which is true for push events, but PR #485 shows that CI does run when:
But CI won't run when:
Current StateThis PR has no recent CI runs because all commits since the initial force pushes have been from Solution (Same as Before)You need to push a commit yourself: git checkout fix/ci-20843503339
git commit --allow-empty -m "chore: trigger CI"
git pushSince you're not a bot, this will trigger the |
Fix for CI not triggering on bot commitsThe root cause of CI not running was that Fixed in #491: Added Going forward, Claude commits on PRs should automatically trigger CI. |
|
@claude Quick test: 1) Run |
Problem
CI failed on main (run 20843503339) due to snapshot mismatch in
test_list_full_working_tree_conflicts.Root Cause
Commit 53d6409 changed
COLUMNSfrom 150 to 500 in test setup, but this snapshot wasn't updated. With the wider terminal, the output format changed:[33m✗[39m(yellow cross, WouldConflict status)[2m↓[22m(dimmed down arrow, Behind status)Fix
Updated the snapshot to match the actual CI output with COLUMNS=500.
Testing
Related
🤖 Automated fix generated by Claude Code