fix(test): extend mtime sleep to Linux for working tree conflicts test #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test_list_full_working_tree_conflicts test was failing intermittently in CI on Ubuntu due to filesystem timestamp precision issues. Git's mtime-based change detection wasn't catching the modified file because the modification happened within the same filesystem timestamp window. The test already had a 100ms sleep for Windows, but Linux CI environments (especially with tmpfs) can have the same issue. The fix is to apply the sleep unconditionally across all platforms. Fixes CI failure from 71b7ea3 Run: https://github.com/max-sixty/worktrunk/actions/runs/20857104231 Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CI failed on main with this test failure:
The
test_list_full_working_tree_conflictstest expected the Status column to show! ✗(working tree conflict + dirty) but got! ↓(working tree conflict + behind) instead. This indicates git didn't detect the modified file.Root Cause
Git's mtime-based change detection wasn't catching the file modification in Ubuntu CI. The test already had a 100ms sleep for Windows (added in #485), but Linux CI environments with tmpfs can have the same timestamp precision issues.
Fix
Remove the
#[cfg(target_os = "windows")]conditional and apply the 100ms sleep unconditionally. This ensures git has time to detect the file change on all platforms.Testing
This is an automated fix for human review.