fix(completion): exclude deprecated args from tab completions #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated args like --no-background were appearing in shell completions when typing `--<TAB>`. This happened because the completion system shows all hidden args when completing `--` (when all candidates are hidden, clap_complete shows them all). Add DEPRECATED_ARGS constant listing args that should never appear in completions, and filter them from completion output. Unlike other hidden args (e.g., --squash which is a valid but hidden toggle), deprecated args should remain hidden even when explicitly requesting option completions. Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--no-backgroundno longer appear in shell completions when typing--<TAB>DEPRECATED_ARGSconstant and filter completions post-generation--no-background(wt remove,wt hook post-start,wt hook post-switch)Context
The completion system shows all hidden args when completing
--(when all candidates are hidden, clap_complete shows them all). This meant deprecated args appeared alongside regular hidden args like--squash. Now deprecated args are filtered out while other hidden toggle flags still appear when explicitly requested.Test plan
cargo test --test integration completion- all 40 completion tests passtest_complete_excludes_deprecated_argsverifies--no-backgrounddoesn't appear for bash/zsh/fish