fix(primary_remote): return error when no remotes configured #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `primary_remote()` fell back to returning "origin" when no
remotes existed, which caused confusing downstream errors (e.g., "remote
'origin' not found") and made callers uncertain (hence redundant
`.unwrap_or("origin")` patterns).
Now returns `Err("No remotes configured")` which:
- Makes the error message match the actual problem
- Lets callers handle the no-remote case explicitly
- Removes the need for defensive fallbacks in callers
Updated callers:
- `branch_exists()`: Returns false if no remotes (can't exist on non-existent remote)
- `branches_for_completion()`: Returns empty vec for remote branches
- `project_identifier()`: Falls through to directory-name fallback
Co-Authored-By: Claude <[email protected]>
Resolved conflicts in primary_remote() by adapting to the new global caching system while maintaining our change to return an error when no remotes are configured. Key adaptations: - Changed cache type from OnceCell<String> to OnceCell<Option<String>> - Closure returns Some(remote) or None instead of String - Function converts None to error after cache lookup Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
primary_remote()to return an error when no remotes are configured instead of falling back to a fictional"origin"Why: Returning
"origin"when no remotes exist caused confusing downstream errors and made callers uncertain (hence redundant.unwrap_or("origin")patterns).Test plan
🤖 Generated with Claude Code