Skip to content

Commit

Permalink
Coveralls hotfix & some additional improvements on GH Actions build p…
Browse files Browse the repository at this point in the history
…rocess (#92)

* Attempt to fix coveralls

* Up

* Fix GH actions

* Update setup-php gh actions step

* No progress for coveralls GH actions step

* Install
  • Loading branch information
maxbanton committed Nov 17, 2020
1 parent 002a9f3 commit 601e88d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
17 changes: 10 additions & 7 deletions .github/workflows/php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ['7.2', '7.3', '7.4']
php-versions: ['7.2', '7.3', '7.4', '8.0']
name: PHP ${{ matrix.php-versions }}
steps:
- name: Checkout
uses: actions/checkout@v1

- name: Setup PHP
uses: shivammathur/setup-php@v1
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-versions }}
extensions: mbstring
Expand All @@ -35,7 +35,7 @@ jobs:
restore-keys: ${{ runner.os }}-composer-

- name: Install dependencies
run: composer install --prefer-dist --no-progress --no-suggest -o
run: composer install --prefer-dist --no-progress -o

- name: Check syntax
run: |
Expand All @@ -45,8 +45,11 @@ jobs:
- name: Run tests
run: vendor/bin/phpunit --coverage-clover build/logs/clover.xml

- name: Send to coveralls
run: php vendor/bin/php-coveralls -v
- name: Upload coverage results to Coveralls
env:
COVERALLS_RUN_LOCALLY: 1
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
composer require php-coveralls/php-coveralls --prefer-dist --no-progress -o
vendor/bin/php-coveralls --coverage_clover=build/logs/clover.xml -v
3 changes: 1 addition & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
"require-dev": {
"maxbanton/dd": "^2.0",
"phpunit/phpunit": "^8.5",
"squizlabs/php_codesniffer": "^3.5",
"php-coveralls/php-coveralls": "^2.2"
"squizlabs/php_codesniffer": "^3.5"
},
"suggest": {
"maxbanton/dd": "Minimalistic dump-and-die function for easy debugging"
Expand Down

0 comments on commit 601e88d

Please sign in to comment.