Skip to content

use .loc instead of list indexing for ranks #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oroelipas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use .loc instead of list indexing for ranks #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scikit_posthocs/_plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ def critical_difference_diagram(

# Sort by lowest rank and filter single-valued sets
crossbar_sets = sorted(
(x for x in crossbar_sets if len(x) > 1), key=lambda x: ranks[list(x)].min()
(x for x in crossbar_sets if len(x) > 1), key=lambda x: ranks.loc[list(x)].min()
)

# Create stacking of crossbars: for each level, try to fit the crossbar,
Expand Down