Bug fixes #119
Merged
Bug fixes #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't unset ghost events when opening the overlay
Cache would be reset to default automatically if it detects that local value is outdated Useful for preventing exceptions when cache schema changed but user's browser still uses the old cache
Don't use sparse arrays
It was temporary disabled when the second layer was added
Fix #114 Fixed by removing the test for time zone offset because this is actually a non issue. The test depends on daylights savings because it runs under users local time, rather than mocks the time Mocking the time would fix this issue. In places were consistent results are needed, the time is already mocked. Everywhere else, it is best not to mock time in order to better approximate real world conditions (e.g, would help detect the cases when some test fails on a given day of the week on in a given part of day)
When overlay is open, none of the content behind it should be focusable or available to screen readers
Durbatuluk1701
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ghost events blinking
Fix auto calendar switcher not working on event page
Allow ignoring all-day events. Fixes #105
Add an option to clear cache and storage
Integrate charts and goals with virtual calendars
Add versioning support to cache
Provide autocomplete for category names
Fix virtual calendar bugs
Improve default layout
Improve event fetching performance
Implement Multi Series Pie chart. Fixes #116
Fix all day events being treated as 2 day events
Fix bugs with events fetching code
Reenable live refresh for Doughnut Chart