-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Family invites #1397
Family invites #1397
Conversation
@zachgoll Thoughts on the self-hosted version of this? Instead of email invites we could just have the admin add a user with a password (then it's their responsibility to give that to whomever they want)? Other option is just show them the invitation URL for them to copy/paste and share on their own? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good.
In regards to self hosters, I think this should work fine
- If a self hoster wants to invite a member to their family, they use this flow (they'll have to configure SMTP on their own, but I think that's reasonable?)
- If a self hoster wants to allow someone else to sign up for their instance, they use the invite codes flow
@Shpigford I guess the one consideration for self hosting that may not work with the email config is users running things on a local network. Rather than having to worry about SMTP stuff, I think I like your idea of just generating a URL with a token that they can copy/paste and send to whoever they want. Since we've got an expiry on the |
Adds the ability to invite family members to your account.