Add CI for testing on PRs #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmyracle
commented
Jan 23, 2024
tmyracle
commented
Jan 23, 2024
| "ci": { | ||
| "headed": true, | ||
| "browser": "chrome" | ||
| } |
There was a problem hiding this comment.
There was one test that was having issues running in headless electron mode, but ran fine on my machine. Running the tests headed on Chrome fixed it. Some discussion here cypress-io/cypress#8606 (comment)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #178
Tested on my forked repo: https://github.com/tmyracle/maybe/actions/runs/7621318372
Steps that still need to be done by someone with access to the repo settings:
The run on this PR will fail until the secrets are added, but should succeed after that. Don't want to merge until the secrets have been configured.