Explicitly get the latest work state when updating heartbeat #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous update_heartbeat method assumed that, if there was a worker update within the update_freq for a given host, there would only be a single instance. However, we have seen cases in the wild where this was not the case. This code guards against this edge-case by using .latest() rather than .get().
swrichards
force-pushed
the
fix-multiple-worker-state-race-condition
branch
from
0fcc604 to
f1e7075
Compare
swrichards
changed the title
alextreme
requested changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous update_heartbeat method assumed that, if there was a worker update within the update_freq for a given host, there would only be a single instance. However, we have seen cases in the wild where this was not the case. This code guards against this edge-case by using .latest() rather than .get().
Intended as a fix for this issue.