[#711] Fix multiple zaaktype versions being used in configuration #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…short procedure config
SilviaAmAm
commented
Feb 27, 2025
| "_expand__zaaktype", flat=True | ||
| zaaktypen = ( | ||
| filterset.qs.order_by( | ||
| "_expand__zaaktype__identificatie", "-_expand__zaaktype__versiedatum" |
There was a problem hiding this comment.
Now we can do the ordering on the date directly in the query. So the bandaid fix for #712 is no longer needed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
==========================================
- Coverage 90.36% 90.27% -0.09%
==========================================
Files 218 218
Lines 6433 6416 -17
Branches 683 684 +1
==========================================
- Hits 5813 5792 -21
- Misses 620 624 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #711
Fixes #718