Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2913] Check for duplicate keys in ZGW imports #1508

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[#2913] Check for duplicate keys in ZGW imports #1508

merged 1 commit into from
Dec 3, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Nov 28, 2024 •
edited
Loading

@pi-sigma pi-sigma changed the title Issue/2913 zgw import export dupes [#2913] Check for duplicate keys in ZGW imports Nov 28, 2024
@pi-sigma pi-sigma force-pushed the issue/2913-zgw-import-export-dupes branch from b91bc32 to 70964c6 Compare December 3, 2024 09:56
@pi-sigma pi-sigma marked this pull request as ready for review December 3, 2024 10:17
@pi-sigma pi-sigma requested a review from swrichards December 3, 2024 10:17
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.32%. Comparing base (0d82080) to head (bcb3da0).
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1508   +/-   ##
========================================
  Coverage    94.31%   94.32%           
========================================
  Files         1068     1068           
  Lines        40386    40405   +19     
========================================
+ Hits         38089    38110   +21     
+ Misses        2297     2295    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

swrichards
swrichards approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few small nitpicks.

@pi-sigma pi-sigma force-pushed the issue/2913-zgw-import-export-dupes branch from 70964c6 to 582d897 Compare December 3, 2024 11:47
@swrichards swrichards self-requested a review December 3, 2024 12:05
@pi-sigma pi-sigma force-pushed the issue/2913-zgw-import-export-dupes branch from 582d897 to bcb3da0 Compare December 3, 2024 13:20
@swrichards swrichards requested a review from alextreme December 3, 2024 14:35
@alextreme alextreme merged commit 692e91b into develop Dec 3, 2024
20 checks passed
@alextreme alextreme deleted the issue/2913-zgw-import-export-dupes branch December 3, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swrichards swrichards swrichards approved these changes

@alextreme alextreme Awaiting requested review from alextreme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pi-sigma @codecov-commenter @swrichards @alextreme