Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12] Add producttype parameters #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Floris272
Copy link
Contributor

Fixes #12

Changes

  • Adds Parameter model with fk to ProductType. (very similar to the recently added model ExterneCode)
  • model is an key value pair and is created within the ProductType post request.
  • the filter ?parameter=[key:value].

@Floris272 Floris272 self-assigned this Feb 25, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.64286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.70%. Comparing base (b42b561) to head (1e732cb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/open_producten/producttypen/views.py 80.00% 1 Missing and 1 partial ⚠️
..._producten/producttypen/serializers/producttype.py 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   85.48%   85.70%   +0.21%     
==========================================
  Files         109      112       +3     
  Lines        2343     2399      +56     
  Branches      154      157       +3     
==========================================
+ Hits         2003     2056      +53     
- Misses        316      317       +1     
- Partials       24       26       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Floris272 Floris272 requested a review from stevenbal February 25, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants