Add typechecking with Pyright #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
force-pushed
the
chore/add-typechecking-to-ci
branch
from
52bd6fc to
4bb3fdd
Compare
sergei-maertens
commented
Nov 29, 2024
There was a problem hiding this comment.
The dependencies require version 2.0.0+, so this import shim was never being used anymore anyway
* Decided to ignore the lookups.py because... well, the Django ORM. * and decided to ignore zgw_consumers.legacy which is scheduled for removal anyway, there are better places to sink our energy into * zgw_consumers/api_models/base.py should be rewritten using pydantic OR be based on TypedDict - the code is not type checker friendly
The type checker correctly points out that the symbol doesn't exist. This code cannot have worked in its 'current' state, so it should be safe to delete.
sergei-maertens
force-pushed
the
chore/add-typechecking-to-ci
branch
from
4bb3fdd to
42a1b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tend to favour Pyright because it's stricter out of the box than mypy, at the cost of not having plugins/support for django-stubs.
Quite some code had to be ignored - lots of it is legacy and/or we don't see a future for it anymore. I hope it doesn't create a culture of suppressing type errors in new code 😬