Allow for even numbered arrays - #3
Merged
Merged
Conversation
mazedlx
reviewed
Apr 29, 2017
mazedlx
left a comment
mazedlx
left a comment
Owner
There was a problem hiding this comment.
Why use $array?
And please remove the whole .idea folder from your PR.
Contributor
Author
|
Just used $array as it was shorter - I will change it back to $this->array and remove the idea folder (I didn't realise it was in there - I thought the ignore file got it! Spot the newb)! |
Contributor
Author
|
Just let me know what else I have to do and I will get on it! Leon |
mazedlx
requested changes
Apr 30, 2017
mazedlx
left a comment
mazedlx
left a comment
Owner
There was a problem hiding this comment.
One last thing: change the variables from snake_case to camelCase.
Then we're good to go 😊
Contributor
Author
|
Done! I also simplified the return statement of even numbered arrays by removing the average_of_midpoints variable, as it seemed redundant! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
Hopefully all the requirements you set are met now!
Thanks
Leon