Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galactic Empire Fixes (FPU + Input) #631

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Galactic Empire Fixes (FPU + Input) #631

merged 9 commits into from
Oct 9, 2024

Conversation

enusbaum
Copy link
Member

  • Refactor CPU Debugging
    • Moved code to "init" on CPU load, not every Tick
    • Added Variable Watching
  • Fix FPU Rounding
    • Fixed FPU Control Word Loading (FLDCW)
    • Utilizes FPU Control Word for Midpoint Rounding Mode
    • Implement FPU Control Word mode for Rounding in FPU OpCodes (FISTP, FRNDINT)
  • Add Extension Method ToHexString() on ReadOnlyArray to print the entire Array
  • Removed Unused Code
  • Added Method Comment on currently Uncommented Code
  • Fix handling of trailing spaces on input in parsein (Trailing NULLs)

@enusbaum
Add Rounding Control Helper Method
41c54ce 
- Adds Helper Method to get the Rounding Control value from the FPU Control Word
@enusbaum
ToHexString Extension
f3c8199 
- Add `ToHexString()` extension method with no parameters to convert the entire span to a hex string
@enusbaum
CPU Fixes
83954a3 
- Refactor Debug Info to be set in constructor, not every `Tick()` (debug performance)
- Add Debug option to Watch Variables (memory addresses) for change
- Fix `FLDCW` to actually load Control Word properly
- Update FPU Methods with rounding to utilize the Rounding Control bytes to define rounding type
- Code Cleanup
@enusbaum
Add missing Method Comment
5c873e5
@enusbaum
Do not count NULL entry as part of MARGC
6a2cd4d
@enusbaum
Remove Unused Code
7300d59
@enusbaum
Update parsein tests
178d5ed 
- Length shouldn't include the terminating null
- Just null should return a length of zero, those zero for expected
- Added Test for trailing space
@enusbaum enusbaum requested a review from paladine August 27, 2024 01:25
@enusbaum
Add Control Word to Unit Test
56339ec
@enusbaum
Update FPU Unit Tests for Rounding Mode
6040f78 
- Add Control Word to Unit Tests for `FLDCW` and `FRNDINT`
- Verify Different Rounding Modes in these Unit Test cases
@paladine paladine merged commit 29bb032 into master Oct 9, 2024
2 checks passed
@paladine paladine deleted the ge-fpu-fixes branch October 9, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paladine paladine paladine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enusbaum @paladine