fix: optimize useObserve

src/lib/binding/useObserve.test.tsx

@@ -1,9 +1,10 @@
 import { afterEach, describe, expect, it } from "vitest"
 import { BehaviorSubject, Subject, map, of, timer } from "rxjs"
 import { useObserve } from "./useObserve"
-import { act, render, renderHook, cleanup } from "@testing-library/react"
-import React, { memo, useEffect, useRef } from "react"
+import { render, renderHook, cleanup } from "@testing-library/react"
+import React, { act, memo, useEffect, useRef } from "react"
 import { useBehaviorSubject } from "./useBehaviorSubject"
+import { waitForTimeout } from "../../tests/utils"
 
 afterEach(() => {
   cleanup()
@@ -180,4 +181,39 @@ describe("useObserve", () => {
 
     expect(await findByText("10")).toBeDefined()
   })
+
+  it(`does not re-render when observer complete`, async () => {
+    const subject = new Subject<number>()
+    let numberOfRenders = 0
+
+    const MyComponent = () => {
+      useObserve(subject)
+
+      numberOfRenders++
+
+      return null
+    }
+
+    render(<MyComponent />)
+
+    expect(numberOfRenders).toBe(1)
+
+    await waitForTimeout(10)
+
+    act(() => {
+      subject.next(10)
+    })
+
+    expect(numberOfRenders).toBe(2)
+
+    await waitForTimeout(10)
+
+    act(() => {
+      subject.complete()
+    })
+
+    await waitForTimeout(10)
+
+    expect(numberOfRenders).toBe(2)
+  })
 })

src/lib/binding/useObserve.ts

@@ -10,8 +10,7 @@ import {
   distinctUntilChanged,
   catchError,
   EMPTY,
-  finalize,
-  type BehaviorSubject
+  type BehaviorSubject,
 } from "rxjs"
 import { useLiveRef } from "../utils/useLiveRef"
 import { primitiveEqual } from "../utils/primitiveEqual"
@@ -88,7 +87,6 @@ export function useObserve<T>(
           tap((value) => {
             valueRef.current = value as any
           }),
-          finalize(next),
           catchError((error) => {
             console.error(error)