Skip to content

mdadm: fix bitmap check #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bkucman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

mdadm: fix bitmap check #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions mdadm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1575,8 +1575,10 @@
}

if (s.btype == BitmapUnknown) {
if (c.runstop != 1 && s.level >= 1 &&
ask("To optimize recovery speed, it is recommended to enable write-intent bitmap, do you want to enable it now?"))
if (s.level == UnSet)
s.btype = BitmapNone;
else if (c.runstop != 1 && s.level >= 1 &&
ask("To optimize recovery speed, it is recommended to enable write-intent bitmap, do you want to enable it now?"))

Check failure on line 1581 in mdadm.c

View workflow job for this annotation

GitHub Actions / checkpatch review 

WARNING:LONG_LINE: line length of 147 exceeds 100 columns

@mwilck mwilck Mar 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation broken?

@bkucman bkucman Mar 11, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is part of the "if" condition, I aligned it with the first argument in parentheses.
but I also see that GH cannot display indents correctly.

Image

If there is another better approach to this let me know.

s.btype = BitmapInternal;
else
s.btype = BitmapNone;
Expand Down
Loading