Skip to content

Commit

Permalink
Build cleanly with cmake "release" (#765)
Browse files Browse the repository at this point in the history 
* require Python 3.7, do MD5 check

* Squashed commit of the following:

commit d028baa
Author: J. Daniel Smith <[email protected]>
Date:   Mon Feb 20 15:01:58 2023 -0500

    hook up HighFive header-only library (#653)

    * no need to catch except::Throwable if it's a std::exception

    * pass testName argument so macros work

    * H5Dvlen_reclaim() is deprecated

    * HighFive unittests run!

    * hookup CHECK_THAT macro

    * Not wrapping HighFive code (it's header-only), move to "drivers"

    * fix casing

    * fix casing

    * get HighFive unittests building on Linux

    * add dependency on 'sys' module

    * compression is enabled by default

    * trying to fix broken unittest

    * reduce static_cast

    * remove a few more compiler warnings

    * trying to figure out failing unittest

    * comment-out failing unittest

    * comment-out failing unittest

    * comment-out failing unittests

    * remove unused unittests

    * Create HighFive-2.6.2.zip

commit 3083b0a
Author: J. Daniel Smith <[email protected]>
Date:   Fri Feb 17 16:54:49 2023 -0500

    Revert "HighFive 2.6.2"

    This reverts commit 396cc3e.

commit 246985a
Author: J. Daniel Smith <[email protected]>
Date:   Fri Feb 17 16:54:45 2023 -0500

    Revert ""build" HighFive HDF5 library"

    This reverts commit b255122.

commit a8b75a5
Author: J. Daniel Smith <[email protected]>
Date:   Fri Feb 17 16:54:41 2023 -0500

    Revert "turn off HighFive Boost support"

    This reverts commit ddc86bb.

commit ec68d5f
Author: J. Daniel Smith <[email protected]>
Date:   Fri Feb 17 16:54:33 2023 -0500

    Revert "Add HighFive unittests"

    This reverts commit d42bde0.

commit f1f85b9
Author: J. Daniel Smith <[email protected]>
Date:   Fri Feb 17 16:54:27 2023 -0500

    Revert "get test_high_five_base more-or-less compiling"

    This reverts commit bb19478.

commit 5ea634e
Author: J. Daniel Smith <[email protected]>
Date:   Fri Feb 17 16:54:22 2023 -0500

    Revert "more work on getting HighFive unittests to build"

    This reverts commit ecc4543.

commit ecc4543
Author: Dan Smith <[email protected]>
Date:   Fri Feb 17 14:35:51 2023 -0500

    more work on getting HighFive unittests to build

commit bb19478
Author: Dan Smith <[email protected]>
Date:   Fri Feb 17 13:56:08 2023 -0500

    get test_high_five_base more-or-less compiling

commit d42bde0
Author: Dan Smith <[email protected]>
Date:   Fri Feb 17 13:22:06 2023 -0500

    Add HighFive unittests

commit ddc86bb
Author: Dan Smith <[email protected]>
Date:   Fri Feb 17 13:16:07 2023 -0500

    turn off HighFive Boost support

commit b255122
Author: Dan Smith <[email protected]>
Date:   Fri Feb 17 13:10:40 2023 -0500

    "build" HighFive HDF5 library

commit 396cc3e
Author: Dan Smith <[email protected]>
Date:   Fri Feb 17 12:51:34 2023 -0500

    HighFive 2.6.2

    https://github.com/BlueBrain/HighFive/releases/tag/v2.6.2

commit 5e5f9d9
Merge: 18ad906 b31f5b6
Author: Dan Smith <[email protected]>
Date:   Fri Feb 17 12:14:46 2023 -0500

    Merge branch 'main' into feature/hdf5

commit 18ad906
Author: Dan Smith <[email protected]>
Date:   Mon Jan 30 10:11:57 2023 -0500

    hdf5Write unittest

commit 3462e11
Author: Dan Smith <[email protected]>
Date:   Mon Jan 30 09:53:22 2023 -0500

    createFile() and writeFile() overloads

commit ecee81d
Author: Dan Smith <[email protected]>
Date:   Mon Jan 30 08:41:59 2023 -0500

    fix typos

commit 197eecf
Author: J. Daniel Smith <[email protected]>
Date:   Sun Jan 29 14:55:31 2023 -0500

    sketch-out hdf5::lite::writeFile()

commit bd23117
Author: J. Daniel Smith <[email protected]>
Date:   Sun Jan 29 13:45:31 2023 -0500

    use SpanRC for writeFile(), not yet implemented

commit ea9af75
Author: J. Daniel Smith <[email protected]>
Date:   Sun Jan 29 13:31:18 2023 -0500

    simple SpanRC to hold a 2D-size and pointer

commit 027c19e
Author: J. Daniel Smith <[email protected]>
Date:   Fri Jan 27 11:15:13 2023 -0500

    createFile() unittest

commit 1f9d07e
Author: J. Daniel Smith <[email protected]>
Date:   Fri Jan 27 11:07:12 2023 -0500

    hook up createFile()

commit 8c7e447
Author: J. Daniel Smith <[email protected]>
Date:   Fri Jan 27 10:30:37 2023 -0500

    start hooking up HDF5 writing

commit 146e0be
Merge: 88ca9fc aabc581
Author: J. Daniel Smith <[email protected]>
Date:   Wed Jan 25 16:15:18 2023 -0500

    Merge branch 'main' into feature/hdf5

commit 88ca9fc
Merge: 42b604b e460970
Author: Dan Smith <[email protected]>
Date:   Wed Jan 18 13:39:14 2023 -0500

    Merge branch 'main' into feature/hdf5

commit 42b604b
Author: Dan Smith <[email protected]>
Date:   Wed Jan 18 10:13:48 2023 -0500

    Squashed commit of the following:

    commit 2ff1c4b
    Author: Dan Smith <[email protected]>
    Date:   Wed Jan 18 10:13:01 2023 -0500

        remove some compiler warnings/diagnostics ... which can cause build failures, depending on options.

    commit 1b57f5f
    Author: Dan Smith <[email protected]>
    Date:   Wed Jan 18 08:59:08 2023 -0500

        the old Intel compiler does have std::make_unique with C++14

    commit 6271bcf
    Merge: 2a7f3d0 9128424
    Author: Dan Smith <[email protected]>
    Date:   Wed Jan 18 08:57:40 2023 -0500

        Merge branch 'main' into develop/remove-cpp11-workarounds

    commit 2a7f3d0
    Merge: 81ac6fa 5736cfd
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 17 10:44:48 2023 -0500

        Merge branch 'main' into develop/remove-cpp11-workarounds

    commit 81ac6fa
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 17 10:24:33 2023 -0500

        trying to get std::make_unique with old Intel compiler

    commit 4730d09
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 17 10:15:56 2023 -0500

        Revert "need to stick with coda_oss::make_unique for now because of old Intel compiler"

        This reverts commit 76ebc4f.

    commit 76ebc4f
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 17 10:13:13 2023 -0500

        need to stick with coda_oss::make_unique for now because of old Intel compiler

    commit 1495dac
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 17 09:12:09 2023 -0500

        is_trivially_copyable for old Intel compiler

commit 10ee602
Merge: 67aa42b 9128424
Author: Dan Smith <[email protected]>
Date:   Wed Jan 18 10:13:41 2023 -0500

    Merge branch 'main' into feature/hdf5

commit 67aa42b
Author: Dan Smith <[email protected]>
Date:   Tue Jan 17 11:33:52 2023 -0500

    restore changes from "main"

commit 8bbfcbf
Author: Dan Smith <[email protected]>
Date:   Tue Jan 17 11:25:13 2023 -0500

    unittests can be simplified to match fewer "view" classes

commit 126bb80
Merge: 3f8ba7a 453b7ec
Author: Dan Smith <[email protected]>
Date:   Tue Jan 17 10:47:18 2023 -0500

    Merge branch 'main' into feature/hdf5

commit 3f8ba7a
Author: Dan Smith <[email protected]>
Date:   Tue Jan 17 10:43:38 2023 -0500

    again, don't need a class just to convert from std::vector<> to std::span<>

commit 24c2b48
Author: Dan Smith <[email protected]>
Date:   Tue Jan 17 10:25:04 2023 -0500

    Squashed commit of the following:

    commit 81ac6fa
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 17 10:24:33 2023 -0500

        trying to get std::make_unique with old Intel compiler

    commit 4730d09
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 17 10:15:56 2023 -0500

        Revert "need to stick with coda_oss::make_unique for now because of old Intel compiler"

        This reverts commit 76ebc4f.

    commit 76ebc4f
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 17 10:13:13 2023 -0500

        need to stick with coda_oss::make_unique for now because of old Intel compiler

    commit 1495dac
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 17 09:12:09 2023 -0500

        is_trivially_copyable for old Intel compiler

commit 2703c11
Author: Dan Smith <[email protected]>
Date:   Tue Jan 17 10:13:36 2023 -0500

    Squashed commit of the following:

    commit 76ebc4f
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 17 10:13:13 2023 -0500

        need to stick with coda_oss::make_unique for now because of old Intel compiler

    commit 1495dac
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 17 09:12:09 2023 -0500

        is_trivially_copyable for old Intel compiler

commit 9d5228a
Author: Dan Smith <[email protected]>
Date:   Tue Jan 17 09:52:54 2023 -0500

    don't need an entire class just to convert a std::vector<> into std::span<>

commit 51bc931
Merge: a84f258 5736cfd
Author: Dan Smith <[email protected]>
Date:   Tue Jan 17 09:32:56 2023 -0500

    Merge branch 'main' into feature/hdf5

commit a84f258
Author: Dan Smith <[email protected]>
Date:   Tue Jan 17 09:14:33 2023 -0500

    Squashed commit of the following:

    commit 1495dac
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 17 09:12:09 2023 -0500

        is_trivially_copyable for old Intel compiler

    commit 7c2aea3
    Author: J. Daniel Smith <[email protected]>
    Date:   Thu Jan 12 16:06:22 2023 -0500

        use H5 SDK naming conventions (#636)

        * sym-links instead of copying files

        * get ready for hdf5.lite enhancdements

        * Revert "sym-links instead of copying files"

        This reverts commit b040c7c.

        * build HDF5 with C89

        * Revert "build HDF5 with C89"

        This reverts commit 680e599.

        * WIN32 no longer automatically defined?

        * break utility routines into smaller pieces for easier reuse

        * put utilities in a separate file for easier reuse

        * utility routine for exception handling

        * put exception handling/conversion in a utility routine

        * use new exception utility routines

        * template to reduce boilerplate when calling try_catch_H5Exceptions

        * explicitly pass return type to template

        * a return_type_of utility is needed to deduce the return type

        * begin filling in FileInfo

        * comment-out "dataset" unittest for now

        * openGroup() to open groups (loc)

        * start filling in GroupInfo

        * start to fill in DatasetInfo

        * start filling in DatasetInfo

        * datasetInfo()

        * groupInfo()

        * incorporation NamedObject from HDF5 docs

        * other values to be filled-in

        * Squashed commit of the following:

        commit 6527f06
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 28 12:17:24 2022 -0500

            use CODA_OSS_TEST_EXCEPTION macro to get right "catch"

        commit 47a833b
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 28 12:05:12 2022 -0500

            what() only when ThrowableEx derives from std::exception

        commit ea7d65a
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 28 11:56:24 2022 -0500

            ThrowableEx inherits from Throwable

        commit 25eb3cf
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 28 11:40:02 2022 -0500

            make it easier to turn off "catch" depending on CODA_OSS_except_Throwable_ISA_std_exception

        commit 7f90078
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 28 11:02:13 2022 -0500

            allow new code to get just std::exception-derived exceptions

        commit 79149db
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 28 10:43:39 2022 -0500

            new macros for new code

        commit 3594f37
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 28 10:37:52 2022 -0500

            Exception11 -> ExceptionEx

        commit ec157c4
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 28 10:31:28 2022 -0500

            making Throwable derived from std::exception by default breaks too much existing code :-(

        commit 5210a3a
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 28 08:51:06 2022 -0500

            use a macro to determine whether except::Throwable derives from std::exception

        commit 49deb0f
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 28 08:34:38 2022 -0500

            catch std::exception after except::Exception

        * No more "11" suffix on exception names

        * skeleton for more sample data

        * pass __FILE__ and __LINE__ from calling site for a more accurate exception message

        * Update test_hdf5info.cpp

        * Matlab code to create sample H5 file

        * Update 123_barfoo_catdog_cx.h5

        * walk through HDF5 sub-groups

        * update sample H5 file

        * sample file has subgroups

        * read in the nested "i" and "r" data

        * test std::span<const std::complex<float>>

        * ComplexArrayView and ComplexParallelView utility classes

        * make it harder to pass the wrong types to ComplexViews

        * tweak class names, make_() and copy() utility routines

        * utility routines to "deconstruct" and array of std::complex

        * nested_complex_float_data_small.h5

        * help the compiler with type deduction

        * read in new sample file

        * trying to make wrong type of buffer fail

        * stepping through copy ctors in the debugger is annoying

        * can't get template magic right for copy_axis()

        * readDatasetT() now throws for the wrong buffer type

        * use TEST_SPECIFIC_EXCEPTION macro instead of try/catch

        * make a simple values() member function to avoid template magic

        * _small.h5 is now (correctly) FLOAT32

        * Jupyter notebook for creating H5 files

        * tweak hdf5.lite dependencies

        * Consistent casing for Dataset, Datatype, Dataspace

        * use the casing from H5 to make copy/pasting code slightly easier

commit c4d2ed6
Author: Dan Smith <[email protected]>
Date:   Mon Jan 16 15:02:53 2023 -0500

    add missing #include guards, fix type in existing #include guard

commit d541525
Author: Dan Smith <[email protected]>
Date:   Mon Jan 16 10:22:35 2023 -0500

    use a single ComplexViewConstIterator for all views

commit 86e6a45
Author: Dan Smith <[email protected]>
Date:   Mon Jan 16 09:44:21 2023 -0500

    CODA_OSS_disable_warning causes GCC errors :-(

commit 5d4b9c2
Author: J. Daniel Smith <[email protected]>
Date:   Sun Jan 15 21:47:53 2023 -0500

    only need an custom iterator for ComplexSpansView

commit d9f0fb1
Author: J. Daniel Smith <[email protected]>
Date:   Sat Jan 14 12:58:27 2023 -0500

    hook up iterators

commit b9329e4
Author: J. Daniel Smith <[email protected]>
Date:   Fri Jan 13 21:26:29 2023 -0500

    initial pass at a ComplexViewConstIterator

commit 6352388
Author: J. Daniel Smith <[email protected]>
Date:   Fri Jan 13 16:19:43 2023 -0500

    remove compiler warning about unused "constexpr" variables

commit b39f609
Author: Dan Smith <[email protected]>
Date:   Thu Jan 12 15:30:19 2023 -0500

    use the casing from H5 to make copy/pasting code slightly easier

commit 0887b13
Merge: bd07df1 fc3008b
Author: Dan Smith <[email protected]>
Date:   Thu Jan 12 14:57:28 2023 -0500

    Merge branch 'main' into feature/hdf5

commit bd07df1
Author: Dan Smith <[email protected]>
Date:   Wed Jan 11 13:45:57 2023 -0500

    Consistent casing for Dataset, Datatype, Dataspace

commit 7acd30e
Author: Dan Smith <[email protected]>
Date:   Wed Jan 11 13:29:52 2023 -0500

    tweak hdf5.lite dependencies

commit 38ab914
Author: Dan Smith <[email protected]>
Date:   Wed Jan 11 11:32:05 2023 -0500

    Jupyter notebook for creating H5 files

commit 95a040e
Author: Dan Smith <[email protected]>
Date:   Wed Jan 11 10:36:11 2023 -0500

    _small.h5 is now (correctly) FLOAT32

commit 107e7c4
Author: Dan Smith <[email protected]>
Date:   Wed Jan 11 09:40:03 2023 -0500

    make a simple values() member function to avoid template magic

commit e1feca9
Author: Dan Smith <[email protected]>
Date:   Wed Jan 11 09:18:15 2023 -0500

    use TEST_SPECIFIC_EXCEPTION macro instead of try/catch

commit 7383336
Author: Dan Smith <[email protected]>
Date:   Tue Jan 10 18:29:28 2023 -0500

    readDatasetT() now throws for the wrong buffer type

commit 6b2cc25
Merge: 86b306d 310f8fd
Author: Dan Smith <[email protected]>
Date:   Tue Jan 10 17:10:19 2023 -0500

    Merge branch 'feature/hdf5' of github.com:mdaus/coda-oss into feature/hdf5

commit 310f8fd
Author: Dan Smith <[email protected]>
Date:   Tue Jan 10 17:09:48 2023 -0500

    can't get template magic right for copy_axis()

commit 86b306d
Author: Dan Smith <[email protected]>
Date:   Tue Jan 10 16:51:28 2023 -0500

    stepping through copy ctors in the debugger is annoying

commit f243e92
Author: Dan Smith <[email protected]>
Date:   Tue Jan 10 16:45:30 2023 -0500

    trying to make wrong type of buffer fail

commit 2b10d96
Author: Dan Smith <[email protected]>
Date:   Tue Jan 10 16:24:04 2023 -0500

    read in new sample file

commit a28e59d
Author: Dan Smith <[email protected]>
Date:   Tue Jan 10 15:45:56 2023 -0500

    help the compiler with type deduction

commit 49bf5e9
Author: Dan Smith <[email protected]>
Date:   Tue Jan 10 15:38:32 2023 -0500

    nested_complex_float_data_small.h5

commit e029325
Author: Dan Smith <[email protected]>
Date:   Tue Jan 10 13:42:28 2023 -0500

    utility routines to "deconstruct" and array of std::complex

commit dede3bd
Merge: 904b1ef b44709a
Author: Dan Smith <[email protected]>
Date:   Tue Jan 10 13:11:04 2023 -0500

    Merge branch 'main' into feature/hdf5

commit 904b1ef
Author: Dan Smith <[email protected]>
Date:   Tue Jan 10 09:54:40 2023 -0500

    tweak class names, make_() and copy() utility routines

commit 8237b9e
Author: J. Daniel Smith <[email protected]>
Date:   Mon Jan 9 21:45:05 2023 -0500

    make it harder to pass the wrong types to ComplexViews

commit 4d9aeda
Author: Dan Smith <[email protected]>
Date:   Mon Jan 9 17:26:34 2023 -0500

    ComplexArrayView and ComplexParallelView utility classes

commit f5e367d
Author: Dan Smith <[email protected]>
Date:   Mon Jan 9 16:29:03 2023 -0500

    test std::span<const std::complex<float>>

commit a4a2844
Author: Dan Smith <[email protected]>
Date:   Mon Jan 9 15:33:50 2023 -0500

    read in the nested "i" and "r" data

commit 1156152
Author: Dan Smith <[email protected]>
Date:   Mon Jan 9 15:28:03 2023 -0500

    sample file has subgroups

commit 8e1b786
Merge: 8c55db7 9f4232a
Author: Dan Smith <[email protected]>
Date:   Mon Jan 9 15:25:54 2023 -0500

    Merge branch 'feature/hdf5' of github.com:mdaus/coda-oss into feature/hdf5

commit 9f4232a
Author: Dan Smith <[email protected]>
Date:   Mon Jan 9 15:25:31 2023 -0500

    update sample H5 file

commit 8c55db7
Author: Dan Smith <[email protected]>
Date:   Mon Jan 9 15:18:05 2023 -0500

    walk through HDF5 sub-groups

commit 7775ed9
Author: Dan Smith <[email protected]>
Date:   Mon Jan 9 14:54:36 2023 -0500

    Update 123_barfoo_catdog_cx.h5

commit 677975d
Author: Dan Smith <[email protected]>
Date:   Mon Jan 9 11:46:22 2023 -0500

    Matlab code to create sample H5 file

commit a0e7dfe
Author: Dan Smith <[email protected]>
Date:   Mon Jan 9 11:17:21 2023 -0500

    Update test_hdf5info.cpp

commit 0b67e16
Author: Dan Smith <[email protected]>
Date:   Mon Jan 9 10:51:23 2023 -0500

    pass __FILE__ and __LINE__ from calling site for a more accurate exception message

commit 86a6773
Author: Dan Smith <[email protected]>
Date:   Mon Jan 9 10:35:39 2023 -0500

    skeleton for more sample data

commit 85f79b0
Merge: 18088e9 986307c
Author: Dan Smith <[email protected]>
Date:   Tue Jan 3 14:42:16 2023 -0500

    Merge branch 'main' into feature/hdf5

commit 18088e9
Merge: 3a1d176 37d7ec7
Author: Dan Smith <[email protected]>
Date:   Tue Jan 3 13:30:01 2023 -0500

    Merge branch 'main' into feature/hdf5

commit 3a1d176
Merge: 1755c69 1582c6a
Author: Dan Smith <[email protected]>
Date:   Wed Dec 28 12:54:51 2022 -0500

    Merge branch 'main' into feature/hdf5

commit 1755c69
Merge: 9ad0154 0622af1
Author: Dan Smith <[email protected]>
Date:   Wed Dec 28 12:38:02 2022 -0500

    Merge branch 'main' into feature/hdf5

commit 9ad0154
Author: Dan Smith <[email protected]>
Date:   Wed Dec 28 12:37:20 2022 -0500

    No more "11" suffix on exception names

commit c20d962
Author: Dan Smith <[email protected]>
Date:   Wed Dec 28 12:31:42 2022 -0500

    Squashed commit of the following:

    commit 6527f06
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 28 12:17:24 2022 -0500

        use CODA_OSS_TEST_EXCEPTION macro to get right "catch"

    commit 47a833b
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 28 12:05:12 2022 -0500

        what() only when ThrowableEx derives from std::exception

    commit ea7d65a
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 28 11:56:24 2022 -0500

        ThrowableEx inherits from Throwable

    commit 25eb3cf
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 28 11:40:02 2022 -0500

        make it easier to turn off "catch" depending on CODA_OSS_except_Throwable_ISA_std_exception

    commit 7f90078
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 28 11:02:13 2022 -0500

        allow new code to get just std::exception-derived exceptions

    commit 79149db
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 28 10:43:39 2022 -0500

        new macros for new code

    commit 3594f37
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 28 10:37:52 2022 -0500

        Exception11 -> ExceptionEx

    commit ec157c4
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 28 10:31:28 2022 -0500

        making Throwable derived from std::exception by default breaks too much existing code :-(

    commit 5210a3a
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 28 08:51:06 2022 -0500

        use a macro to determine whether except::Throwable derives from std::exception

    commit 49deb0f
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 28 08:34:38 2022 -0500

        catch std::exception after except::Exception

commit c88cee9
Author: Dan Smith <[email protected]>
Date:   Mon Dec 26 12:13:02 2022 -0500

    other values to be filled-in

commit bca4a4e
Author: Dan Smith <[email protected]>
Date:   Mon Dec 26 12:01:42 2022 -0500

    incorporation NamedObject from HDF5 docs

commit 61fa68f
Author: Dan Smith <[email protected]>
Date:   Mon Dec 26 11:54:23 2022 -0500

    groupInfo()

commit 460e7d7
Author: Dan Smith <[email protected]>
Date:   Mon Dec 26 11:49:22 2022 -0500

    datasetInfo()

commit 14eb9b7
Author: Dan Smith <[email protected]>
Date:   Mon Dec 26 11:23:11 2022 -0500

    start filling in DatasetInfo

commit afe5f1c
Author: Dan Smith <[email protected]>
Date:   Mon Dec 26 10:53:40 2022 -0500

    start to fill in DatasetInfo

commit 77a968c
Author: Dan Smith <[email protected]>
Date:   Mon Dec 26 10:38:29 2022 -0500

    start filling in GroupInfo

commit d81bcdf
Author: Dan Smith <[email protected]>
Date:   Mon Dec 26 09:27:31 2022 -0500

    openGroup() to open groups (loc)

commit a0cd294
Author: J. Daniel Smith <[email protected]>
Date:   Fri Dec 23 12:56:27 2022 -0500

    comment-out "dataset" unittest for now

commit 86e0060
Author: J. Daniel Smith <[email protected]>
Date:   Fri Dec 23 11:45:44 2022 -0500

    begin filling in FileInfo

commit 366dda6
Author: J. Daniel Smith <[email protected]>
Date:   Fri Dec 23 11:39:46 2022 -0500

    a return_type_of utility is needed to deduce the return type

commit e219282
Author: J. Daniel Smith <[email protected]>
Date:   Fri Dec 23 11:27:50 2022 -0500

    explicitly pass return type to template

commit 4937ccd
Author: J. Daniel Smith <[email protected]>
Date:   Fri Dec 23 11:05:48 2022 -0500

    template to reduce boilerplate when calling try_catch_H5Exceptions

commit b3b5ebd
Author: J. Daniel Smith <[email protected]>
Date:   Fri Dec 23 10:33:54 2022 -0500

    use new exception utility routines

commit ea1c03e
Author: J. Daniel Smith <[email protected]>
Date:   Fri Dec 23 10:29:06 2022 -0500

    put exception handling/conversion in a utility routine

commit 819a99d
Author: J. Daniel Smith <[email protected]>
Date:   Fri Dec 23 10:22:27 2022 -0500

    utility routine for exception handling

commit 6f34eea
Author: J. Daniel Smith <[email protected]>
Date:   Fri Dec 23 10:04:53 2022 -0500

    put utilities in a separate file for easier reuse

commit fcbde4f
Author: J. Daniel Smith <[email protected]>
Date:   Fri Dec 23 09:53:06 2022 -0500

    break utility routines into smaller pieces for easier reuse

commit 52358ea
Author: J. Daniel Smith <[email protected]>
Date:   Thu Dec 22 18:03:56 2022 -0500

    WIN32 no longer automatically defined?

commit 5a42864
Author: J. Daniel Smith <[email protected]>
Date:   Thu Dec 22 16:55:16 2022 -0500

    Revert "build HDF5 with C89"

    This reverts commit 680e599.

commit 680e599
Author: Dan Smith <[email protected]>
Date:   Mon Dec 19 13:27:10 2022 -0500

    build HDF5 with C89

commit a87a071
Merge: 8447c1a 1384b8a
Author: Dan Smith <[email protected]>
Date:   Mon Dec 19 13:25:49 2022 -0500

    Merge branch 'main' into feature/hdf5

commit 8447c1a
Author: Dan Smith <[email protected]>
Date:   Tue Dec 13 14:11:33 2022 -0500

    Revert "sym-links instead of copying files"

    This reverts commit b040c7c.

commit fb60b56
Merge: fa06f04 edd3e8f
Author: Dan Smith <[email protected]>
Date:   Tue Dec 13 10:21:55 2022 -0500

    Merge branch 'main' into feature/hdf5

commit fa06f04
Author: Dan Smith <[email protected]>
Date:   Tue Dec 13 10:02:09 2022 -0500

    get ready for hdf5.lite enhancdements

commit b040c7c
Author: Dan Smith <[email protected]>
Date:   Tue Dec 13 09:21:14 2022 -0500

    sym-links instead of copying files

* Get a whole bunch of standard C++ headers with a single #include; broke-man's "import module std;"

* add 'override' as suggested by the compiler

* add 'override' as suggested by the compiler

* turn on suggest-final-types and suggest-final-methods

* =delete copy/assignment

* add ENABLE_ASAN option ... trying to figure out WAF unittest failures

* a few tweaks to get rid of some ASAN diagnostics; trying to figure out HDF5 failures

* fix ASAN-detected memory leaks

* is there any harm in always enabling ASAN?

* vector::reserve() micro-optimization

* turn off "there is no warning number" warning

* be sure parameter is used to avoid compiler warning

* remove compiler warnings from .H files

* `noexcept` and `const` to reduce compiler warnings

* fix build error in NITRO

* use add_compile_options() rather than adjusting CMAKE_CXX_FLAGS

* "volatile" means "special memory" and has nothing to do with threading

* Revert "use add_compile_options() rather than adjusting CMAKE_CXX_FLAGS"

This reverts commit 817cd0c.

* #define NDEBUG, if necessary

* support "PlatformToolset" as a special environment variable

* remove compiler warnings

* turn on some more GCC warnings for our code

* enable more GCC warnings

* get rid of a bunch of C-style casts

* adjust warnings; links to GCC docs

* fix -Wshadow warnings

* get rid of more C-style casts

* fix compiler error on server

* fix -Wsuggest-override

* fix -Wzero-as-null-pointer-constant

* -Wsuggest-final-types -Wsuggest-final-methods

* TEST_ALMOST_EQ

* -Wdouble-promotion doesn't add much value

* fix some -Wconversion warnings

* A windows .H already has float_t

* adjust compiler warnings

* fix more compiler warnigns

* manage Xerces #include files from a single spot

* manage HDF5 #include files from a single spot

* rename #include file nobody else should use

* #pragma-away existing warnings, turn on warnings-as-errors

* Global initializer calls a non-constexpr function '...' (i.22).

* NULL -> nullptr

* use std::ignore to ignore return values

* Switch statement does not cover all cases. Consider adding a '...' label (es.79).

* Do not use function style casts (es.49). Prefer '...' over '...'..

* fix some "noexcept" diagnostics

* Using uninitialized memory '...'.

* The function '...' is constexpr, mark variable '...' constexpr if compile-time evaluation is desired (con.5).

* You can attempt to make '...' constexpr unless it contains any undefined behavior (f.4).

* '...': assignment operator was implicitly defined as deleted

* put similar suppressions together

* turn off #include -> import

* NULL -> nullptr

* suppress compiler warnings from external files

* Incorrect operator.  Use an equality test to check for zero-valued flags.

* Incorrect operator.  Did you intend to use || instead?

* Dereferencing NULL pointer '...'.

* Potential comparison of a constant with another constant.

* changes from NITRO

* try to make it clearer that types::zfloat is the same as std::complex<float>

* don't enable standard preprocessor

* remove another auto_ptr work-around

* Per TIFF spec, "offset" MUST be a 32-bit value!

* trust that set(CMAKE_CXX_STANDARD 14) will do the right thing

* turn off new 5267) // definition of implicit copy constructor for '...' is deprecated because it has a user-provided destructor

* speed up builds w/fewer #includes

* #pragma warning: there is no warning number '...'

* #including <import/sys.h> is slow

* Don't #include <import/sys.h> in TestCase.h as that slows down builds

* fix compiler warning about order of operations

* explicitly build Linux for Release and Debug

* compile-time SIMDInstructionSet value

* trying to fix CMake build

* fix compile-time getSIMDInstructionSet()

* virtual destructor to fix ASAN diagnostic

* The exceptions leak memory which causes an ASAN diagnostic on Linux.

* turn on ASAN for builds from YAML

* ASAN not quite ready on Windows yet

* work-around Windows ASAN diagnostic

* turn off unittest only if ASAN is enabled

* use __SANITIZE_ADDRESS__ and _MSC_VER to limit ASAN bug work-around

* Revert "ASAN not quite ready on Windows yet"

This reverts commit ed3788b.

* highfive fails appear to be ASAN bugs in older VS

* Revert "Revert "ASAN not quite ready on Windows yet""

This reverts commit 118c033.

* another ASAN bug in VS2020 17.3

* adjust permissions for extracted files

* update hash

* use std::ssize() to avoid static_cast<size_t>

* use std::ssize() to avoid static_cast<size_t>

* remove overloads taking C-style array

* no reason to derive from `cli::Results`

* makeValue() utility

* make_unique instead of explicit `new`

* most uses of getValue() can be const

* use range `for`

* more use of make_unique

* use std::unique_ptr for underlying storage

* return a reference to the stored std::unique_ptr

* common code for put()

* don't use std::unique_ptr in "getter" APIs

* avoid memory leaks with more use of unique_ptr

* simplify toType<bool>()

* turn off /Wall for MSVC

 https://github.com/microsoft/STL/wiki/Changelog#vs-2022-179-preview-1
> *Note*: `/Wall` is not intended for regular production use, as it contains a large number of
> extremely noisy and low-value warnings. In general, the STL does not attempt to be `/Wall` clean.

* exports used by NITRO

* CODA_OSS_DLL shouldn't be on the command-line

* allow CMake to switch between building SHARED (DLLs) or STATIC libraires

* turn off/fix some more compiler warnings
  • Loading branch information
J. Daniel Smith authored Jan 22, 2024
1 parent 625b286 commit d723792
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 18 deletions.
11 changes: 11 additions & 0 deletions cmake/CodaBuild.cmake
View file
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,17 @@ macro(coda_initialize_build)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)

# Turn on AVX2 by default ... it's from 2013.
# Well, no :-( ... it seems to cause crashes w/older
# compilers on build servers. :-(
set(ENABLE_AVX2 false)
set(ENABLE_AVX512F false)
#if (NOT ENABLE_AVX512F)
# if (NOT DISABLE_AVX2)
# set(ENABLE_AVX2 true)
# endif()
#endif()

# MSVC-specific flags and options.
if (MSVC)
set_property(GLOBAL PROPERTY USE_FOLDERS ON)
Expand Down
9 changes: 6 additions & 3 deletions modules/c++/CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ if (MSVC)

elseif (UNIX)
# https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
add_compile_options(-Werror) # Make all warnings into errors
#add_compile_options(-Werror) # Make all warnings into errors
add_compile_options(-Wall -Wextra -Wpedantic -pedantic-errors -Wunused)

add_compile_options(-Wzero-as-null-pointer-constant)
add_compile_options(-Wsuggest-final-types -Wsuggest-final-methods)
#add_compile_options(-Wsuggest-final-types -Wsuggest-final-methods)
add_compile_options(-Wsuggest-override)
add_compile_options(-Woverloaded-virtual)
add_compile_options(-Warray-bounds)
#add_compile_options(-Warray-bounds)
add_compile_options(-Wduplicated-branches -Wduplicated-cond)
add_compile_options(-Wtrampolines)
add_compile_options(-Wshadow)
Expand All @@ -29,6 +29,9 @@ elseif (UNIX)

add_compile_options(-Wno-double-promotion) # implicit conversion of `float` to `double` is fine

add_compile_options(-Wno-array-bounds) # TODO: fix the code!
add_compile_options(-Wno-maybe-uninitialized) # TODO: fix the code!

# Need a newer compiler than GCC 9
#add_compile_options(-Wnrvo)
endif()
Expand Down
22 changes: 7 additions & 15 deletions modules/c++/sys/source/AbstractOS.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,7 @@ void AbstractOS::appendEnv(const std::string& envVar, const std::vector<std::str
static std::string getSpecialEnv_PID(const AbstractOS& os, const std::string& envVar)
{
assert((envVar == "$") || (envVar == "PID"));
#if _MSC_VER
UNREFERENCED_PARAMETER(envVar);
#endif
CODA_OSS_mark_symbol_unused(envVar);
const auto pid = os.getProcessId();
return std::to_string(pid);
}
Expand All @@ -284,8 +282,8 @@ static std::string getSpecialEnv_USER(const AbstractOS& os, const std::string& e
{
// $USER on *nix, %USERNAME% on Windows; make it so either one always works
assert((envVar == "USER") || (envVar == "USERNAME"));
CODA_OSS_mark_symbol_unused(envVar);
#if _WIN32
UNREFERENCED_PARAMETER(envVar);
return os.getEnv("USERNAME");
#else
return os.getEnv("USER");
Expand All @@ -297,8 +295,8 @@ static std::string getSpecialEnv_HOME(const AbstractOS& os, const std::string& e
// $HOME on *nix, %USERPROFILE% on Windows; make it so either one always works
assert((envVar == "HOME") || (envVar == "USERPROFILE"));

CODA_OSS_mark_symbol_unused(envVar);
#ifdef _WIN32
UNREFERENCED_PARAMETER(envVar);
constexpr auto home = "USERPROFILE";
#else // assuming *nix
// Is there a better way to support ~ on *nix than $HOME ?
Expand All @@ -323,9 +321,7 @@ static std::string getSpecialEnv_HOME(const AbstractOS& os, const std::string& e
static std::string getSpecialEnv_Configuration(const AbstractOS&, const std::string& envVar)
{
assert(envVar == "Configuration");
#if _MSC_VER
UNREFERENCED_PARAMETER(envVar);
#endif
CODA_OSS_mark_symbol_unused(envVar);
// in Visual Studio, by default this is usually "Debug" and "Release"
return sys::debug_build() ? "Debug" : "Release";
}
Expand All @@ -334,8 +330,8 @@ static std::string getSpecialEnv_Platform(const AbstractOS&, const std::string&
assert((envVar == "Platform") || (envVar == "HOSTTYPE"));

// in Visual Studio, this is "Win32" (maybe "x86") or "x64"
CODA_OSS_mark_symbol_unused(envVar);
#ifdef _WIN32
UNREFERENCED_PARAMETER(envVar);
#ifdef _WIN64
return "x64";
#else
Expand All @@ -350,9 +346,7 @@ static std::string getSpecialEnv_Platform(const AbstractOS&, const std::string&
static std::string getSpecialEnv_PlatformToolset(const AbstractOS&, const std::string& envVar)
{
assert(envVar == "PlatformToolset");
#if _MSC_VER
UNREFERENCED_PARAMETER(envVar);
#endif
CODA_OSS_mark_symbol_unused(envVar);

#ifdef _WIN32
// https://docs.microsoft.com/en-us/cpp/build/how-to-modify-the-target-framework-and-platform-toolset?view=msvc-160
Expand Down Expand Up @@ -386,9 +380,7 @@ static std::string getSpecialEnv_SECONDS(const AbstractOS&, const std::string& e
// https://www.gnu.org/software/bash/manual/html_node/Bash-Variables.html
// "This variable expands to the number of seconds since the shell was started. ..."
assert(envVar == "SECONDS");
#if _MSC_VER
UNREFERENCED_PARAMETER(envVar);
#endif
CODA_OSS_mark_symbol_unused(envVar);
return getSpecialEnv_SECONDS_();
}

Expand Down

0 comments on commit d723792

Please sign in to comment.