fix: return bad error after parallel running

mdelapenya · Jul 9, 2022 · 0c1f6b2 · 0c1f6b2
1 parent 3c8722d
commit 0c1f6b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/parallel.go b/parallel.go
@@ -114,7 +114,7 @@ func ParallelContainers(ctx context.Context, reqs ParallelContainerRequest, opt
 
 	<-waitRes
 
-	if len(errors) == 0 {
+	if len(errors) != 0 {
 		return containers, ParallelContainersError{Errors: errors}
 	}
 

diff --git a/parallel_test.go b/parallel_test.go
@@ -3,6 +3,8 @@ package testcontainers
 import (
 	"context"
 	"testing"
+
+	"github.com/stretchr/testify/require"
 )
 
 func TestParallelContainers(t *testing.T) {
@@ -100,6 +102,7 @@ func TestParallelContainers(t *testing.T) {
 			res, err := ParallelContainers(context.Background(), tc.reqs, ParallelContainersOptions{})
 
 			if err != nil {
+				require.NotZero(t, tc.expErrors)
 				e, _ := err.(ParallelContainersError)
 
 				if len(e.Errors) != tc.expErrors {