MAINT: improve conversion of masked values to Python scalars #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Willl close gh-28
Turns out there are some tests that currently depend on
__bool__and__index__to be defined for masked values. For instance, thatxp.all([])is True makes sense in some applications, and this sort of logic is relied on in some tests. Note thatmxp.all(mxp.asarray([]))currently returns a masked True, as it does when all elements of the argument are masked. With the current behavior, this evaluates toTruewhen forced to be boolean, consistent withxp.all([]), but now it raises. Perhapsallon an empty array should return a non-masked True?I'll have to a take a closer look at the tests to see if we really rely on this behavior or if tests just need to be refactored.