Add support for manuscripts with no current holdings#10
Open
mdholloway wants to merge 1 commit intomainfrom
Open
Add support for manuscripts with no current holdings#10mdholloway wants to merge 1 commit intomainfrom
mdholloway wants to merge 1 commit intomainfrom
Conversation
- Add NoCurrentHoldingException for manuscripts with zero current holdings - Add MultipleCurrentHoldingsException for manuscripts with multiple current holdings - Refactor DsMeta#initialize to use specific exceptions instead of generic error - Extract holdings validation logic into private method for better code organization - Add comprehensive test coverage for both exception scenarios - Fix Rubocop violations with improved test structure and verified doubles Resolves issue #9 - allows wikibase_to_solr script to handle manuscripts without current holdings gracefully by catching NoCurrentHoldingException. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
Author
|
Hey Doug, sorry it took me a little bit to get to this! If this looks good to you, I'll merge and release a new version and follow up with a change to the wikibase_to_solr script in the Blacklight repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #9 - allows wikibase_to_solr script to handle manuscripts without current holdings gracefully by catching NoCurrentHoldingException.
🤖 Generated with Claude Code