Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When testing with local server, show editor with more realistic width #166

Open
schalkneethling opened this issue Oct 26, 2018 · 0 comments
Labels
community Contributions by the community effort: medium This task is a medium effort. enhancement Improves an existing feature. p3 We don't have visibility when this will be addressed.

Comments

@schalkneethling
Copy link
Contributor

Duplicate of mdn/interactive-examples#811 - work on this will happen here.

Original report from @chrisdavidmills

I just thought — when writing the interactive examples we always try to make both the example and the code lines narrow enough so they fit comfortably inside their respective panes.

But when you text it locally, the editor is shown at the full screen width, which is a lot wider than it'll actually be shown in the content column on MDN.

It would be great to have an option to set it to the typical MDN content column size instead. I could resize my browser, but I'm lazy ;-)

Latest comment by @stephanmax - mdn/interactive-examples#811 (comment)

Just realized that this is more complicated than I thought.

My initial plan was to bundle in some CSS with the editor styles that makes sure the code demos are embedded in a more realistic surrounding. But if I understand mdn-bob correctly, this bundled CSS would also end up in the production demos.

What do you think @schalkneethling, can we add an env variable to the npm scripts to only add the mdn mock CSS when building locally/testing code demos?

@schalkneethling schalkneethling added enhancement Improves an existing feature. community Contributions by the community labels Oct 26, 2018
@caugner caugner added effort: medium This task is a medium effort. p3 We don't have visibility when this will be addressed. labels Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Contributions by the community effort: medium This task is a medium effort. enhancement Improves an existing feature. p3 We don't have visibility when this will be addressed.
Projects
Development

No branches or pull requests

2 participants