-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples for BigInt API #1380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Elchi3 and sorry to take so long reviewing.
Thanks for the review, @wbamberg. Sorry to have poked about this one, but I thought it would be great to land it this week since we're shipping and advertising it. Addressed your comments. Great feedback as always! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Elchi3 , looks great. I also noticed that the "expected output" included quotes for the bigint values in asIntN()
and asUintN()
, which it should not.
Since it's a trivial change to remove the quotes I just made it so as to avoid another review round.
Thanks for the quick fix! ❤️ |
Examples for: