Add missing css.properties.display.flow feature#24386
Add missing css.properties.display.flow feature#24386queengooborg wants to merge 2 commits intomdn:mainfrom
Conversation
This PR adds the missing `flow` member of the `display` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.12.3). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/display/flow
caugner
left a comment
There was a problem hiding this comment.
I think we'd need to test manually that display: flow has the specified effect.
| "firefox": { | ||
| "version_added": "≤72" | ||
| }, |
There was a problem hiding this comment.
According to https://bugzil.la/1657594, Firefox may not actually support it:
The Compatibility panel should indicate that
display: flowis converted todisplay:blockin Firefox,
There was a problem hiding this comment.
Discussed with Vinyl, and the question is whether it's always display:block, or if it is converted to the default value for the element (e.g. display: inline for <span>)
There was a problem hiding this comment.
So I generated a test case with ChatGPT: https://developer.mozilla.org/de/play?id=h%2BLlW3ImqADHCJYkMw2xE%2BjFSvlfWApNyUj1hSyEa2VSWUgXOu84ObYg3ftPQZ74pE8GnTGvbE18Lg0V
Tested in Chrome 131, Firefox Nightly 134.0a1 (2024-11-21), and Safari 18.1.1.
All browsers do not seem to support flow, i.e. the computed value is block.
But maybe that's in accordance to the spec:
Otherwise it generates a block container box.
So I came up with another (ChatGPT-generated) test case that sets style.display and reads it again: https://developer.mozilla.org/en-US/play?id=UGBq0JaWyjIGJz8nqIEbFux3a3rDR5mS3uppv7pl%2Bn03MxTNx0%2B%2BXNGDjtIzkD0ICNQbWIjuTJQKhQJm
And this test also fails in all three browsers engines. 🤔
There was a problem hiding this comment.
|
Looking at the table in the spec, it looks like This is in accordance with the spec:
@queengooborg Was your intention to document flow layout support (likely supported from the beginning), or support for the |
This PR adds the missing
flowmember of thedisplayCSS property. The data comes from the mdn-bcd-collector project (v10.12.3).Check out the collector's guide on how to review this PR.
Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/display/flow