Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version number for sync support for Firefox for Android #24525

Closed
wants to merge 1 commit into from

Conversation

danielhjacobs
Copy link
Contributor

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1253740#c471, with that code "chrome.storage.sync will be present on Android, but it won't actually sync".

Summary

https://bugzilla.mozilla.org/show_bug.cgi?id=1253740 says it's milestone mozilla52, but I decided to assume the current data for desktop Firefox support was correct and match to that (version 53).

This needs the "KR: Real BCD" label

Test results and supporting details

Not tested, but see the below bug which seems to indicate that this was added in Firefox for Android at the same time as Firefox for desktop (with the caveats already mentioned in the note):

https://bugzilla.mozilla.org/show_bug.cgi?id=1253740#c471

Related issues

openwebdocs/project#206

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1253740#c471, with that code "chrome.storage.sync will be present on Android, but it won't actually sync".
@github-actions github-actions bot added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Sep 25, 2024
@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Sep 25, 2024

Between this and everything listed as https://github.com/mdn/browser-compat-data/labels/KR%3A%20Real%20BCD%20%3Akey%3A, the only true values that will be left after all those PRs and this are merged are on https://github.com/mdn/browser-compat-data/blob/main/webextensions/api/privacy.json:

Edit: Opened #24527 based on these findings.

@danielhjacobs
Copy link
Contributor Author

Requesting review from @Rob--W

@queengooborg queengooborg added the KR: Real BCD Key Result: Eliminate true/null values and replace them with "real" values. label Sep 26, 2024
@mathewhodson
Copy link

Enabled by default in Firefox 53 with https://bugzilla.mozilla.org/show_bug.cgi?id=1331467

In Firefox 52, it was disabled by the "webextensions.storage.sync.enabled" preference.

@Rob--W
Copy link
Member

Rob--W commented Sep 29, 2024

Thanks for this PR. I am closing it however because the same BCD is being updated (expanded with many more sub entries) in #24272, and one of the requested changes is to set the correct version information for Android: #24272 (review)

@Rob--W Rob--W closed this Sep 29, 2024
@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Sep 29, 2024

@Rob--W That PR doesn't actually touch the same line as this PR (line 445). If you mean @rebloor should do so in that PR that's fine though. This is the current line 445 in its new location in that PR: https://github.com/mdn/browser-compat-data/pull/24272/files#diff-c7fffa05f34168c98f7e5d9049c7b805bc10fc57a2fdfb13f63a8694ec0f7385R992 (in that PR it's line 992)

@danielhjacobs
Copy link
Contributor Author

@Rob--W
Copy link
Member

Rob--W commented Sep 30, 2024

Here is a recap of the requested changes that also makes sure to mention this line: #24272 (comment)

I mentioned a rudimentary preview tool at #24272 (comment) to make it easier to check version information. If you use that table, it is obvious that most entries under sync is incorrect. If this PR were to have been merged before that other one was created, then the linter would have complained because 48 < 53. Now, since I expect that other PR to finalize within a few days, I'll just avoid touching the BCD data to avoid merge conflicts.

@danielhjacobs danielhjacobs mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions KR: Real BCD Key Result: Eliminate true/null values and replace them with "real" values.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants