Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing statements for webview_ios #24657

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −10
Draft

Add missing statements for webview_ios #24657

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0151dba
Add missing web-features fields for webview_ios
RupertBenWiser Oct 7, 2024
9895b55
Merge branch 'main' into main
caugner Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions html/elements/del.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
"webview_android": "mirror",
"webview_ios": "mirror"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes this error:

 ✖ html.elements.del - Error → Basic support in webview_ios was declared implemented in a later version (3.2) than the following sub-feature(s):
        → html.elements.del.cite: 2
        → html.elements.del.datetime: 2

However, the same applies to Safari, which says 3 for the subfeature and ≤4 for the parent feature. So I'm not sure why it only fails for the subfeature?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to an issue with mirroring where the downstream browser became a non-range no matter what. This will be resolved by #24155!

},
"status": {
"experimental": false,
Expand Down Expand Up @@ -105,7 +106,8 @@
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
Expand Down
3 changes: 2 additions & 1 deletion html/elements/fieldset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
Expand Down
9 changes: 6 additions & 3 deletions html/elements/iframe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,8 @@
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
Expand Down Expand Up @@ -567,7 +568,8 @@
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
Expand Down Expand Up @@ -1418,7 +1420,8 @@
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
Expand Down
6 changes: 4 additions & 2 deletions html/elements/ins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
Expand Down Expand Up @@ -105,7 +106,8 @@
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
Expand Down
3 changes: 2 additions & 1 deletion html/elements/link.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,7 +724,8 @@
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
Expand Down
3 changes: 2 additions & 1 deletion html/elements/meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,8 @@
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
Expand Down
Loading