-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nodejs data for URL
#24997
Open
skyclouds2001
wants to merge
7
commits into
mdn:main
Choose a base branch
from
skyclouds2001:node-URL
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update nodejs data for URL
#24997
+46
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
label
Nov 8, 2024
caugner
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just one issue:
github-actions
bot
added
the
data:browsers 🌍
Data about browsers (versions, release dates, etc). This data is used for validation.
label
Nov 13, 2024
github-actions
bot
added
the
merge conflicts 🚧
This PR needs to merge latest "main" branch to resolve a merge conflict or other issue.
label
Nov 18, 2024
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
This PR needs to merge latest "main" branch to resolve a merge conflict or other issue.
label
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
data:api 🐇
Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
data:browsers 🌍
Data about browsers (versions, release dates, etc). This data is used for validation.
nodejs
Data about Node.js
size:m
[PR only] 25-100 LoC changed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the basic support of
URL
is first added in v7.0.0, later added to v6.13.0URL
class implement is added in v7.0.0, via nodejs/node#7448, and backlogged to v6.13.0URL.prototype.toJSON()
implement is added in v7.7.0, via nodejs/node#11236, and backlogged to v6.13.0the issue for
URL.prototype.searchParams
which will return an empty list when init is got fixed in v7.3.0, via nodejs/node#9484, and backlogged to v6.13.0Test results and supporting details
https://nodejs.org/docs/latest/api/globals.html#url
https://nodejs.org/docs/latest/api/url.html#class-url
https://nodejs.org/en/blog/release/v6.13.0/
https://nodejs.org/en/blog/release/v7.0.0/
https://nodejs.org/en/blog/release/v10.0.0/
Related issues
see also nodejs/node#55806
see also #24998