Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & fix node.js data for PerformanceObserver and PerformanceObserverEntryList #25001

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 8, 2024

Summary

the API is avaiable in v8.5.0 and expose to global in v19.0.0

note that the data for supportedEntryTypes is not correct, this should shipped in v16.0.0, confirmed by release note and implement PR

also note that PerformanceObserverEntryList hasn't exposed before v16.7.0, though available as internal instance, see release note and impl pr

Test results and supporting details

see also

https://nodejs.org/docs/latest/api/globals.html#performanceobserver
https://nodejs.org/docs/latest/api/perf_hooks.html#class-performanceobserver
https://nodejs.org/docs/latest/api/globals.html#performanceobserverentrylist
https://nodejs.org/docs/latest/api/perf_hooks.html#class-performanceobserverentrylist

test in local node runtime

image
image

Related issues

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 8, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 8, 2024 12:40
@caugner caugner added the nodejs Data about Node.js label Nov 12, 2024
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 18, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 18, 2024
@github-actions github-actions bot added the size:m [PR only] 25-100 LoC changed label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API nodejs Data about Node.js size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants