Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome for Android supports webkitdirectory on input #25036

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Chrome for Android supports webkitdirectory on input #25036

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bccc4e1
Chromium supports webkitdirectory on mobile
danielhjacobs Nov 11, 2024
6330c6b
Merge branch 'main' into danielhjacobs-patch-1
caugner Nov 12, 2024
0992f11
Fix webkitdirectory support data issues
danielhjacobs Nov 13, 2024
7212e2d
chore: Fix JSON
danielhjacobs Nov 13, 2024
de11b3e
Add notes about webkitdirectory properly
danielhjacobs Nov 20, 2024
fff0ace
chore: Fix formatting
danielhjacobs Nov 20, 2024
dc9ebf7
Add html.elements.input.webkitdirectory
danielhjacobs Nov 21, 2024
ad9bdd0
web: Apply review suggestion
danielhjacobs Nov 21, 2024
b95e6c4
Apply suggestions from code review
danielhjacobs Nov 23, 2024
9ab5002
chore: Fix formatting
danielhjacobs Nov 23, 2024
dbf3dbf
chore: Properly reference bug number
danielhjacobs Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions api/HTMLInputElement.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3011,11 +3011,18 @@
"chrome": {
"version_added": "7"
},
"chrome_android": {
"version_added": false,
"impl_url": "https://crbug.com/40248532",
"notes": "The property can be set, but has no effect."
},
"chrome_android": [
{
"version_added": "131",
"notes": "In Chrome for Android 131, choosing a directory crashes the browser."
danielhjacobs marked this conversation as resolved.
Show resolved Hide resolved
},
{
"version_added": "18",
"impl_url": "https://crbug.com/40248532",
"partial_implementation": true,
"notes": "The property can be set, but has no behavior."
danielhjacobs marked this conversation as resolved.
Show resolved Hide resolved
}
],
"edge": {
"version_added": "13"
},
Expand Down
57 changes: 57 additions & 0 deletions html/elements/input.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1380,6 +1380,63 @@
"deprecated": true
}
}
},
"webkitdirectory": {
"__compat": {
"support": {
"chrome": {
"version_added": "7"
},
"chrome_android": [
{
"version_added": "132"
},
{
"version_added": "131",
"partial_implementation": true,
"notes": "In Chrome for Android 131, choosing a directory crashes the browser (see [bug 376834374](https://crbug.com/376834374))."
},
{
"version_added": "18",
"impl_url": "https://crbug.com/40248532",
"partial_implementation": true,
"notes": "The property can be set, but has no behavior."
}
danielhjacobs marked this conversation as resolved.
Show resolved Hide resolved
],
"edge": {
"version_added": "13"
},
"firefox": {
"version_added": "50"
},
"firefox_android": {
"version_added": false
},
"ie": {
"version_added": false
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "11.1"
},
"safari_ios": {
"version_added": "11.3",
"impl_url": "https://webkit.org/b/271705",
"partial_implementation": true,
"notes": "The property can be set, but has no behavior."
danielhjacobs marked this conversation as resolved.
Show resolved Hide resolved
},
"samsunginternet_android": "mirror",
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
"standard_track": false,
"deprecated": false
}
}
}
}
}
Expand Down