Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox 133 supports onwaitingforkey event handler property on nHTMLMediaElement #25119

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

hamishwillee
Copy link
Contributor

FF133 adds support for the onwaitingforkey content attribute in https://bugzilla.mozilla.org/show_bug.cgi?id=1925952

Verified using this test on browserstack FF132 and 133 - works on the later, stalls on the former for onwaitingforkey: https://wpt.live/encrypted-media/media-element-event-handler-attributes.html

I did this by marking the old event version as partial.

Related docs can be tracked in mdn/content#36558

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 19, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question regarding the partial support before 133.

api/HTMLMediaElement.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the size:s [PR only] 7-24 LoC changed label Nov 22, 2024
@hamishwillee hamishwillee requested a review from caugner November 24, 2024 22:25
@hamishwillee
Copy link
Contributor Author

Can I please get this merged.

@caugner caugner changed the title FF133 HTMLMediaElement add onwaitingforkey event handler Firefox 133 supports onwaitingforkey event handler property on nHTMLMediaElement Nov 26, 2024
@caugner caugner merged commit 82837a5 into mdn:main Nov 26, 2024
7 checks passed
@hamishwillee hamishwillee deleted the ff133_waitingforkey_event branch November 29, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:s [PR only] 7-24 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants