-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(http): Clarify Trailer support, partial support for Server-Timing in Fx devtools only #25141
base: main
Are you sure you want to change the base?
Conversation
…ng in Fx devtools only
FWIW I only found this indirectly related WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=178069 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit.
http/headers/Server-Timing.json
Outdated
"description": "`Server-Timing` as HTTP trailer", | ||
"support": { | ||
"chrome": { | ||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, we should probably add the Chromium impl_url here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, thanks for the reminder
Summary
The support for HTTP Trailer header is misleading, as it's removed from the Fetch spec & not accessible there anyway / XHR. As far as I can see, the only support that exists in browsers is exclusively for
Server-Timing
, and at that, it's only used for DevTools in Network -> Timing, all other headers (as trailers) are a no-op / discarded. For this reason, I've set it to partial support forTrailer
, and full support for Server-Timing header as trailer, which no other browser appears to do.Test results and supporting details
Firefox
Server-Timing
implementation bug -> https://bugzilla.mozilla.org/show_bug.cgi?id=1403051:ChrBugs -> https://issues.chromium.org/issues/40811358
Node repro:
Related issues