Add mask border properties #7384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:css
|
ah I can't use true for Chrome anymore. Well, my best guess is these went into Safari 3.1, based on this 2008 blog post https://webkit.org/blog/181/css-masks/ which would put it into Chrome 1 I think? I've updated the others based on that, unless anyone has better knowledge. |
ddbeck
requested changes
Jan 13, 2021
There was a problem hiding this comment.
A few small issues to resolve here before merging. Thank you, @rachelandrew!
Co-authored-by: Daniel D. Beck <[email protected]>
|
@ddbeck thanks - I think I've covered those requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking at the missing BCD reported in mdn/sprints#3436
This PR is for the
mask-border-properties. These have no support but most are implemented with a different name, prefixed in Safari and Chrome. I haven't been able to find out exactly when these versions went into Webkit, but Safari 6 seems to have them and Chrome 30, as I tested them.