Skip to content

Correct data errors in certain CSS interfaces.#7627

Closed
jpmedley wants to merge 1 commit intomasterfrom
typedom
Closed

Correct data errors in certain CSS interfaces.#7627
jpmedley wants to merge 1 commit intomasterfrom
typedom

Conversation

@jpmedley
Copy link
Copy Markdown
Contributor

The corrects a few errors with some CSS interfaces.

None of them have @@iterator which must be present in the the IDL. They are in neither the spec, nor Chrome's implemention of it:

The setters and getters listed in the IDL were misinterpreted as functions. For example, instead of there being a method named CSSNumericArray.CSSNumbericValue there is actually the ability to treat an instance of the interface as an array. In other words, CSSNumbericArray[n] would be a valid programming reference.

@github-actions github-actions Bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 10, 2020
@jpmedley
Copy link
Copy Markdown
Contributor Author

cc: @rachelandrew

@ddbeck
Copy link
Copy Markdown
Contributor

ddbeck commented Jan 7, 2021

None of them have @@iterator which must be present in the the IDL.

Do iterable declarations not imply the @@iterator symbol? It looks like all three have the declaration.

This possibly relates to #6367.

@foolip
Copy link
Copy Markdown
Contributor

foolip commented Jan 15, 2021

Do iterable declarations not imply the @@iterator symbol? It looks like all three have the declaration.

These three interfaces all have iterable<T> declarations in https://drafts.css-houdini.org/css-typed-om/, and https://heycam.github.io/webidl/#es-iterable is what says that results in a @@iterator property being added. (A bunch of other things are also implied, and it's worth knowing that which are different for iterable<T> and iterable<K, V>.)

@ddbeck
Copy link
Copy Markdown
Contributor

ddbeck commented Jan 28, 2021

Hi @jpmedley, do you plan to come back to this PR?

@jpmedley
Copy link
Copy Markdown
Contributor Author

jpmedley commented Feb 1, 2021

I shouldn't have removed @@iterator. The reason I thought it should be removed is because I'm still confused about. It doesn't look to me like you ever write this in a script. What you actually write is instanceVariable[Symbol.iterator](). Is so, then that's what needs to be in the BCD.

If we need to discuss that first, I'll happily put @@iterator back for now.

@ddbeck
Copy link
Copy Markdown
Contributor

ddbeck commented Feb 11, 2021

@jpmedley If you want to change the way BCD names the iterator symbol, then I think we need to take that up under a separate issue. The @@ notation for well-known symbols seems conventional within BCD and on MDN (see Array's @@iterator for an example); if we're going to change one, we ought to be consistent about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants