Add declarativeNetRequest #22644

rebloor · 2022-11-30T22:07:37Z

Description

Adding the declarativeNetRequest API.

Rob--W

Here is an initial review pass.

General notes:

Drop the MV3 mention; as the API is going to be available to MV2 too. In Chrome/Safari there are no MV restrictions.
Drop the Edge/Chromium boilerplate at the end of all articles.

Specific note: the structure of this draft seems copied from Chromium's documentation at https://developer.chrome.com/docs/extensions/reference/declarativeNetRequest/ . That structure is not great, as it is auto-generated from Chromium's implementation at https://source.chromium.org/chromium/chromium/src/+/main:extensions/common/api/declarative_net_request.idl , which includes many single-use types. Documentation would be more readable when these single-use types are merged with the method that "imports" the type definition.

files/en-us/mozilla/add-ons/webextensions/api/declarativeNetRequest/domaintype/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativeNetRequest/dynamic_ruleset_id/index.md

...mozilla/add-ons/webextensions/api/declarativeNetRequest/getavailablestaticrulecount/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativeNetRequest/getenabledrulesets/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativeNetRequest/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativeNetRequest/requestmethod/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativeNetRequest/updateruleoptions/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativeNetRequest/domaintype/index.md

rebloor · 2022-12-08T23:28:35Z

@Rob--W "Documentation would be more readable when these single-use types are merged with the method that "imports" the type definition." As explained elsewhere, this is what I believe I've already done - can you provide more specific examples?

Co-authored-by: Rob Wu <[email protected]>

github-actions · 2022-12-09T15:58:24Z

Preview URLs (34 pages)

Flaws (48)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request
Title: declarative_net_request
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.manifest.declarative_net_request

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest
Title: declarativeNetRequest
Flaw count: 5

broken_links:
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/manifest.json/permissions#host_permissions
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request
bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/testMatchOutcome
Title: declarativeNetRequest.testMatchOutcome
Flaw count: 2

broken_links:
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest#testing
bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.testMatchOutcome

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/setExtensionActionOptions
Title: declarativeNetRequest.setExtensionActionOptions
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.setExtensionActionOptions

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/updateDynamicRules
Title: declarativeNetRequest.updateDynamicRules
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.updateDynamicRules

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/RuleCondition
Title: declarativeNetRequest.RuleCondition
Flaw count: 2

broken_links:
- Can't resolve /docs/Web/API/URL
bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.RuleCondition

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/SESSION_RULESET_ID
Title: declarativeNetRequest.SESSION_RULESET_ID
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.SESSION_RULESET_ID

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/MAX_NUMBER_OF_REGEX_RULES
Title: declarativeNetRequest.MAX_NUMBER_OF_REGEX_RULES
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.MAX_NUMBER_OF_REGEX_RULES

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/DYNAMIC_RULESET_ID
Title: declarativeNetRequest.DYNAMIC_RULESET_ID
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.DYNAMIC_RULESET_ID

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/GUARANTEED_MINIMUM_STATIC_RULES
Title: declarativeNetRequest.GUARANTEED_MINIMUM_STATIC_RULES
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.GUARANTEED_MINIMUM_STATIC_RULES

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/ResourceType
Title: declarativeNetRequest.ResourceType
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.ResourceType

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/getEnabledRulesets
Title: declarativeNetRequest.getEnabledRulesets
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.getEnabledRulesets

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/URLTransform
Title: declarativeNetRequest.URLTransform
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.URLTransform

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/onRuleMatchedDebug
Title: declarativeNetRequest.onRuleMatchedDebug
Flaw count: 2

broken_links:
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest#testing
bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.onRuleMatchedDebug

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/RuleAction
Title: declarativeNetRequest.RuleAction
Flaw count: 3

broken_links:
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/manifest.json/permissions#host_permissions
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest#permissions
bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.RuleAction

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/ModifyHeaderInfo
Title: declarativeNetRequest.ModifyHeaderInfo
Flaw count: 2

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.RuleAction.requestHeaders
- No BCD data for query: webextensions.api.declarativeNetRequest.RuleAction.responseHeaders

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/getSessionRules
Title: declarativeNetRequest.getSessionRules
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.getSessionRules

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/Redirect
Title: declarativeNetRequest.Redirect
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.Redirect

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/MAX_NUMBER_OF_STATIC_RULESETS
Title: declarativeNetRequest.MAX_NUMBER_OF_STATIC_RULESETS
Flaw count: 2

broken_links:
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request
bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.MAX_NUMBER_OF_STATIC_RULESETS

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/getAvailableStaticRuleCount
Title: declarativeNetRequest.getAvailableStaticRuleCount
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.getAvailableStaticRuleCount

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/GETMATCHEDRULES_QUOTA_INTERVAL
Title: declarativeNetRequest.GETMATCHEDRULES_QUOTA_INTERVAL
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.GETMATCHEDRULES_QUOTA_INTERVAL

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/Rule
Title: declarativeNetRequest.Rule
Flaw count: 3

broken_links:
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest#rules
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest#matching_precedents
bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.Rule

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES
Title: declarativeNetRequest.MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/getDynamicRules
Title: declarativeNetRequest.getAvailableStaticRuleCount
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.getDynamicRules

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/MatchedRule
Title: declarativeNetRequest.MatchedRule
Flaw count: 3

broken_links:
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest#rulesets
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request
bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.MatchedRule

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/MAX_GETMATCHEDRULES_CALLS_PER_INTERVAL
Title: declarativeNetRequest.MAX_GETMATCHEDRULES_CALLS_PER_INTERVAL
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.MAX_GETMATCHEDRULES_CALLS_PER_INTERVAL

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/updateSessionRules
Title: declarativeNetRequest.updateSessionRules
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.updateSessionRules

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/MAX_NUMBER_OF_ENABLED_STATIC_RULESETS
Title: declarativeNetRequest.MAX_NUMBER_OF_ENABLED_STATIC_RULESETS
Flaw count: 2

broken_links:
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request
bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.MAX_NUMBER_OF_ENABLED_STATIC_RULESETS

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/isRegexSupported
Title: declarativeNetRequest.isRegexSupported
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.isRegexSupported

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/updateEnabledRulesets
Title: declarativeNetRequest.updateEnabledRulesets
Flaw count: 2

broken_links:
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request
bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.updateEnabledRulesets

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/getMatchedRules
Title: declarativeNetRequest.getMatchedRules
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.api.declarativeNetRequest.getMatchedRules

External URLs (7)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest
Title: declarativeNetRequest

https://extensionworkshop.com/documentation/develop/web-ext-command-reference/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/RuleCondition
Title: declarativeNetRequest.RuleCondition

https://en.wikipedia.org/wiki/Punycode (3 times) (Note! This may be a new URL 👀)
declarativeNetRequest API: have isUrlFilterCaseSensitive condition set to false by default w3c/webextensions#269 (1 time) (Note! This may be a new URL 👀)
Regular expressions in DNR API (regexFilter) w3c/webextensions#344 (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/ResourceType
Title: declarativeNetRequest.ResourceType

https://github.com/WICG/webpackage (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/webRequest/ResourceType
Title: webRequest.ResourceType

(comment last updated: 2023-02-12 17:46:20)

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/resourcetype/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/index.md

Rob--W

(Only replied to comments and the context around the comments, haven't done a full review yet)

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/modifyheaderinfo/index.md

Rob--W · 2023-02-01T20:44:31Z

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/index.md

+
+If the request is not blocked or redirected, the matching `modifyHeaders` rules are evaluated, with the most recently installed extensions getting priority. Within each extension, all `modifyHeaders` rules with a priority lower than matching `allow` or `allowAllRequests` rules are ignored.
+
+If multiple `modifyHeaders` rules specify the same header, the resulting modification for the header is determined based on the priority of each rule and the operations specified:


files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/resourcetype/index.md

Rob--W · 2023-02-01T20:52:10Z

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/resourcetype/index.md

+
+{{AddonSidebar()}}
+
+The resource type of a request.


Suggested change

The resource type of a request.

The resource type of a request. Comparable to {{WebExtAPIRef('webRequest.ResourceType')}}.

The set of supported types is at https://searchfox.org/mozilla-central/rev/9dfda5ccb0fc42d7666a54b1caf1af6525e49694/toolkit/components/extensions/schemas/declarative_net_request.json#71-93 and https://source.chromium.org/chromium/chromium/src/+/main:extensions/common/api/declarative_net_request.idl;l=12-28;drc=b141211e0c65628cf86a68a37d92377186560560

I'll also suggest some deletions below of obsolete types. Please double-check that the content here and the BCD is accurate.

@Rob--W So, comparing those lists it seems that quite a number of these items are supported in Chrome:

How can we check what is supported in Safari?

I have asked an Apple engineer about the support state. Let's be concerned with what we know (Chrome and Firefox), and correct support information about Apple in a follow-up PR if needed.

I've updated the BCD

I got an answer back from @xeenon . Safari's list of supported ResourceTypes is:

"font" "image" "main_frame" "media" "other" "ping" "script" "stylesheet" "sub_frame" "websocket" "xmlhttprequest"

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/modifyheaderinfo/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/modifyheaderinfo/index.md

Rob--W · 2023-02-06T18:44:51Z

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/resourcetype/index.md

+
+{{AddonSidebar()}}
+
+The resource type of a request.


I have asked an Apple engineer about the support state. Let's be concerned with what we know (Chrome and Firefox), and correct support information about Apple in a follow-up PR if needed.

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/resourcetype/index.md

Co-authored-by: Rob Wu <[email protected]>

Rob--W

I did another full pass over the content and it generally looks good.

I added several suggested edits, to add content, improve the accuracy, fix broken links, minor formatting improvements. Feel free to edit my suggested edit before committing the changes as you see fit.

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/index.md

...s/mozilla/add-ons/webextensions/api/declarativenetrequest/max_number_of_regex_rules/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/matchedrule/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/modifyheaderinfo/index.md

Rob--W · 2023-02-09T20:06:11Z

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/resourcetype/index.md

+
+{{AddonSidebar()}}
+
+The resource type of a request.


I got an answer back from @xeenon . Safari's list of supported ResourceTypes is:

"font" "image" "main_frame" "media" "other" "ping" "script" "stylesheet" "sub_frame" "websocket" "xmlhttprequest"

...s/mozilla/add-ons/webextensions/api/declarativenetrequest/setextensionactionoptions/index.md

Rob--W · 2023-02-09T20:13:16Z

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/ruleaction/index.md

+- `requestHeaders` {{optional_inline}}
+  - : {{WebExtAPIRef("declarativeNetRequest.ModifyHeaderInfo")}}. The request headers to modify for the request. Only valid if `RuleActionType` is `"modifyHeaders"`.
+- `redirect` {{optional_inline}}
+  - : {{WebExtAPIRef("declarativeNetRequest.ModifyHeaderInfo")}}. The response headers to modify for the request. Only valid if `RuleActionType` is `"modifyHeaders"`.


Suggested change

- `requestHeaders` {{optional_inline}}

- : {{WebExtAPIRef("declarativeNetRequest.ModifyHeaderInfo")}}. The request headers to modify for the request. Only valid if `RuleActionType` is `"modifyHeaders"`.

- `redirect` {{optional_inline}}

- : {{WebExtAPIRef("declarativeNetRequest.ModifyHeaderInfo")}}. The response headers to modify for the request. Only valid if `RuleActionType` is `"modifyHeaders"`.

- `requestHeaders` {{optional_inline}}

- : {{WebExtAPIRef("declarativeNetRequest.ModifyHeaderInfo")}}. The request headers to modify for the request. Only valid if the action `type` is `"modifyHeaders"`.

- `redirect` {{optional_inline}}

- : {{WebExtAPIRef("declarativeNetRequest.ModifyHeaderInfo")}}. The response headers to modify for the request. Only valid if the action `type` is `"modifyHeaders"`.

Co-authored-by: Rob Wu <[email protected]>

…uleAction.responseHeaders Corrected markdown issues in ModifyHeaderInfo

Rob--W

I did a final pass over every detail of the PR and added some final suggested edits. After these, the PR can be merged. Since it's a matter of just committing the suggested edits and there is not much to discuss about it, I'll approve the PR so it does not need another round of review.

...d-ons/webextensions/api/declarativenetrequest/max_number_of_enabled_static_rulesets/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/onrulematcheddebug/index.md

...s/mozilla/add-ons/webextensions/api/declarativenetrequest/setextensionactionoptions/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/testmatchoutcome/index.md

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/updatedynamicrules/index.md

files/en-us/mozilla/add-ons/webextensions/manifest.json/index.md

Rob--W

Since it's a matter of just committing the suggested edits and there is not much to discuss about it, I'll approve the PR so it does not need another round of review.

Now actually marking as approved - but don't forget to commit the suggested edits!

Co-authored-by: Rob Wu <[email protected]>

Rob--W

Thanks for all your work on this Richard!

Add declarativeNetRequest

59611bd

rebloor added the Content:WebExt WebExtensions docs label Nov 30, 2022

rebloor requested review from rpl and Rob--W November 30, 2022 22:07

rebloor self-assigned this Nov 30, 2022

github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Nov 30, 2022

rebloor added 4 commits December 3, 2022 03:47

Added properties

b73189a

Add functions and events

0aef595

Added manifest and permissions details

d5750c5

Added API narrative + corrections

1005f78

Rob--W reviewed Dec 8, 2022

View reviewed changes

rebloor and others added 7 commits December 9, 2022 12:36

Function > Method, deleted unused DomainType

fd67a1e

Merge branch 'main' into add-declarativeNetRequest

6f75ef7

Suggestions from review

ac598a6

Co-authored-by: Rob Wu <[email protected]>

Removed references to MV3 and source boilerplate note

1b0d933

Minor feedback updates

4b60d4e

Dropping RequestMethod

a8e4706

UpdateRuleOptions moved to updateDynamicRules and updateSessionRules

d0a72a4

rebloor requested a review from Rob--W December 9, 2022 03:37

Merge branch 'main' into add-declarativeNetRequest

eef29ca

rebloor mentioned this pull request Dec 9, 2022

Add declarativeNetRequest mdn/browser-compat-data#18403

Merged

3 tasks

correct folder name

75928fc

rebloor added 2 commits December 13, 2022 09:53

Merge branch 'main' into add-declarativeNetRequest

47195a4

testing + rule scope clarifications

61d5928

rebloor marked this pull request as ready for review December 13, 2022 22:12

rebloor requested a review from a team as a code owner December 13, 2022 22:12

rebloor added 2 commits December 14, 2022 11:12

Merge branch 'main' into add-declarativeNetRequest

fa603c0

nested type to additional object

4ea4944

rebloor added 3 commits February 1, 2023 14:18

Enable testing details links

aac62de

RuleCondition feedback

453b060

Added details of types to ResourceType

75a53f3

rebloor commented Feb 1, 2023

View reviewed changes

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/resourcetype/index.md Show resolved Hide resolved

MatchedRule.rulesetId return value clarification

15552f0

rebloor commented Feb 1, 2023

View reviewed changes

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/index.md Outdated Show resolved Hide resolved

rebloor requested a review from Rob--W February 1, 2023 18:10

Rob--W reviewed Feb 1, 2023

View reviewed changes

rebloor added 2 commits February 4, 2023 06:31

Removed xbl from ResourceType in webRequest & declarativeNetRequest

e52fd1d

Moved modify header precedence details

d36fb76

rebloor commented Feb 5, 2023

View reviewed changes

files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/modifyheaderinfo/index.md Outdated Show resolved Hide resolved

Rob--W reviewed Feb 6, 2023

View reviewed changes

rebloor and others added 5 commits February 7, 2023 12:07

Apply suggestions from review

3769bbd

Co-authored-by: Rob Wu <[email protected]>

Merge branch 'main' into add-declarativeNetRequest

415f04f

Correct list markdown

524c495

Note about ModifyHeaderInfo.operation limitations

dc0e5c5

ModifyHeaderInfo BCD added to RuleAction

b6a0f4b

Rob--W requested changes Feb 9, 2023

View reviewed changes

rebloor and others added 4 commits February 11, 2023 05:20

typo redirect to responseHeaders

b236295

Apply suggestions from review

a70ccae

Co-authored-by: Rob Wu <[email protected]>

BCD for ModifyHeaderInfo represented by RuleAction.requestHeaders & R…

2789805

…uleAction.responseHeaders Corrected markdown issues in ModifyHeaderInfo

Merge branch 'main' into add-declarativeNetRequest

98c2f98

Rob--W reviewed Feb 12, 2023

View reviewed changes

Rob--W approved these changes Feb 12, 2023

View reviewed changes

Apply suggestions from review

7173fd6

Co-authored-by: Rob Wu <[email protected]>

Rob--W approved these changes Feb 12, 2023

View reviewed changes

Testing required preference comment

3f5d857

rebloor merged commit ef4f820 into mdn:main Feb 14, 2023

rebloor deleted the add-declarativeNetRequest branch February 14, 2023 22:31

rebloor mentioned this pull request Feb 17, 2023

Add missing subfeatures to webextensions.api.webRequest.ResourceType mdn/browser-compat-data#18869

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add declarativeNetRequest #22644

Add declarativeNetRequest #22644

rebloor commented Nov 30, 2022 •

edited

Loading

Rob--W left a comment

rebloor commented Dec 8, 2022

github-actions bot commented Dec 9, 2022 •

edited

Loading

Rob--W left a comment

Rob--W Feb 1, 2023

Rob--W Feb 1, 2023

rebloor Feb 3, 2023

Rob--W Feb 6, 2023

rebloor Feb 7, 2023

Rob--W Feb 9, 2023

Rob--W Feb 6, 2023

Rob--W left a comment

Rob--W Feb 9, 2023

Rob--W Feb 9, 2023

Rob--W left a comment

Rob--W left a comment

Rob--W left a comment


		If the request is not blocked or redirected, the matching `modifyHeaders` rules are evaluated, with the most recently installed extensions getting priority. Within each extension, all `modifyHeaders` rules with a priority lower than matching `allow` or `allowAllRequests` rules are ignored.

		If multiple `modifyHeaders` rules specify the same header, the resulting modification for the header is determined based on the priority of each rule and the operations specified:

	The resource type of a request.
	The resource type of a request. Comparable to {{WebExtAPIRef('webRequest.ResourceType')}}.

Add declarativeNetRequest #22644

Add declarativeNetRequest #22644

Conversation

rebloor commented Nov 30, 2022 • edited Loading

Description

Rob--W left a comment

Choose a reason for hiding this comment

rebloor commented Dec 8, 2022

github-actions bot commented Dec 9, 2022 • edited Loading

Rob--W left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rob--W left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rob--W left a comment

Choose a reason for hiding this comment

Rob--W left a comment

Choose a reason for hiding this comment

Rob--W left a comment

Choose a reason for hiding this comment

rebloor commented Nov 30, 2022 •

edited

Loading

github-actions bot commented Dec 9, 2022 •

edited

Loading