-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(http): Refresh headers ~[s->x] #36862
Conversation
files/en-us/web/http/headers/service-worker-navigation-preload/index.md
Outdated
Show resolved
Hide resolved
This pull request has merge conflicts that must be resolved before it can be merged. |
Yes, I can imagine - thank you very much 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bsmth
I've added few minor comments/nits which you may or may not wish to consider. I think this all works. Approving for you to merge when you are happy,
Thank you Hamish for the patience and review rounds on this, the feedback has been really valuable 🙏🏻 I'm going to land this one now and look at the TODOs as follow-up tasks. |
You are most welcome. Feels good when stuff like this goes in! |
Description
This PR refreshes a few HTTP headers pages.
common changes:
The HTTP **`Header-Name`** (request|response) header
in first sentence{{HTTPStatus("406", "406 Not Acceptable")}}
Motivation
Keeping content up-to-date, fixing formatting, unifying writing conventions
Additions:
TODOs