Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify desc format for SVG elements #36883

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Conversation

skyclouds2001
Copy link
Contributor

Description

Motivation

Additional details

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 20, 2024 15:51
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner November 20, 2024 15:51
@skyclouds2001 skyclouds2001 requested review from hamishwillee and removed request for a team November 20, 2024 15:51
@github-actions github-actions bot added Content:SVG SVG docs size/m [PR only] 51-500 LoC changed labels Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Preview URLs (40 pages)
External URLs (2)

URL: /en-US/docs/Web/SVG/Element/feColorMatrix
Title: <feColorMatrix>


URL: /en-US/docs/Web/SVG/Element/vkern
Title: <vkern>

(comment last updated: 2024-11-24 22:58:14)

@bsmth bsmth requested a review from pepelsbey November 20, 2024 15:53
@bsmth
Copy link
Member

bsmth commented Nov 20, 2024

Thanks for this! I'm going to anticipate that Hamish will suggest also updating the SVG element page template to be explicit about this if we're going ahead with this format. I've updated the HTTP header template page with a quote block with how we expect the first sentence should look if you want to use that for inspiration.

edit: also adding in Pepelsbey who might have opinions on the SVG intro format :)

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much. I did a minor tweak. All looks good!

Update to template as per #36883 (comment) can happen as a post process.

@hamishwillee hamishwillee merged commit da99ca1 into mdn:main Nov 24, 2024
8 checks passed
@skyclouds2001 skyclouds2001 deleted the desc-svg branch November 25, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:SVG SVG docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants