Mark depthCompare and depthWriteEnabled as optional, and add explanation #36886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdavidmills
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
3 tasks
|
Preview URLs |
| @@ -52,7 +52,7 @@ The `depthStencil` object can contain the following properties: | |||
| - : A number representing the maximum depth bias of a fragment. If omitted, `depthBiasClamp` defaults to 0. | |||
| - `depthBiasSlopeScale` {{optional_inline}} | |||
| - : A number representing a depth bias that scales with the fragment's slope. If omitted, `depthBiasSlopeScale` defaults to 0. | |||
| - `depthCompare` | |||
| - `depthCompare` {{optional_inline}} | |||
There was a problem hiding this comment.
Those changes apply to https://developer.mozilla.org/en-US/docs/Web/API/GPUDevice/createRenderPipelineAsync as well I believe
There was a problem hiding this comment.
Yes, but we don't duplicate the descriptor descriptions on both pages. We just include them in full on the createRenderPipeline() ref page, and then link there from the createRenderPipelineAsync() ref page.
There was a problem hiding this comment.
sideshowbarker
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Chrome 120, the
depthCompareanddepthWriteEnabledproperties of thecreateRenderPipeline/createRenderPipelineAsyncdescriptors have been made optional when not needed. See https://developer.chrome.com/blog/new-in-webgpu-120#changes_to_depth-stencil_state.This PR marks both properties as optional and adds an explanation of when they are not needed.
Motivation
Additional details
Related issues and pull requests
Project issue: #36370