Fix syntax & structure format for svg gradient related features #36887
+118
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:SVG
Preview URLs (16 pages)
Flaws (1)Note! 15 documents with no flaws that don't need to be listed. 🎉 URL:
(comment last updated: 2024-11-23 04:50:11) |
skyclouds2001
commented
Nov 20, 2024
skyclouds2001
commented
Nov 20, 2024
skyclouds2001
commented
Nov 20, 2024
skyclouds2001
commented
Nov 20, 2024
skyclouds2001
requested review from
hamishwillee and
bsmth
and removed request for
a team
There was a problem hiding this comment.
Looks great. Just one question https://github.com/mdn/content/pull/36887/files#r1853277235
|
Removing myself from review as Hamish has got this covered 👍🏻 |
Co-authored-by: Hamish Willee <[email protected]>
hamishwillee
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
for svg attributes, change spec-urls key to browser-compat key and add Browser compatibility section
fix syntax for
cxcyrx1x2y1y2attributescombine linearGradient and radialGradient section for
hrefattribute, since the two sections has almost the same contentMotivation
Additional details
https://svgwg.org/svg2-draft/pservers.html#LinearGradientElement
https://svgwg.org/svg2-draft/pservers.html#RadialGradientElement
Related issues and pull requests
see also mdn/browser-compat-data#25150