fix: link to Window.postMessage rather than MessagePost.postMessage #37252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong postMessage method was referenced here. The frame.contentWindow returns a Window, which is a different postMessage and only the Window's postMessage implementation has the correct 3-argument signature as used in the example.
activescott
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
|
Preview URLs (comment last updated: 2024-12-18 03:43:55) |
wbamberg
reviewed
Dec 18, 2024
wbamberg
approved these changes
Dec 18, 2024
allan-bonadio
pushed a commit
to allan-bonadio/content
that referenced
this pull request
Dec 25, 2024
…dn#37252) * fix: link to Window.postMessage rather than MessagePost.postMessage The wrong postMessage method was referenced here. The frame.contentWindow returns a Window, which is a different postMessage and only the Window's postMessage implementation has the correct 3-argument signature as used in the example. * Update files/en-us/web/api/messagechannel/port2/index.md --------- Co-authored-by: wbamberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The wrong postMessage method was referenced here. The frame.contentWindow returns a Window, which is a different postMessage and only the Window's postMessage implementation has the correct 3-argument signature as used in the example.
Motivation
More accurate documentation -confusing to follow that link and not see the actual overload used in the example.