Made JS Expected output comments consistent with actual output #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our CI does not like irregular whitespace. And it's fine to use regular spaces here; the goal is not to compare the output character by character. Could you revert those space changes and possibly add some text like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a few
// Expected output: ...comments in JS examples. In some cases these comments weren't consistent with what JS engines output, in other cases, the formatting was inconsistent with how the interactive example console formats things.Note that for currency formatting (e.g. bigint-tolocalestring.js), JS engines produce a non-breaking space U+00A0 instead of an ASCII space U+0032.