Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete untranslated content - glossary #14972

Merged
merged 2 commits into from
Aug 8, 2023
Merged

delete untranslated content - glossary #14972

merged 2 commits into from
Aug 8, 2023

Conversation

hochan222
Copy link
Member

#14965 의 glossary 폴더 부분입니다.

@hochan222 hochan222 requested a review from a team as a code owner August 8, 2023 12:24
@hochan222 hochan222 requested review from yechoi42 and removed request for a team August 8, 2023 12:24
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Aug 8, 2023
@hochan222
Copy link
Member Author

@yin1999, Hello! There seems to be an error in DIFF_DOCUMENTS. Can you check the current issue? https://github.com/mdn/translated-content/blob/main/.github/workflows/pr-check-lint_content.yml (cc. @queengooborg )

image

@queengooborg
Copy link
Collaborator

queengooborg commented Aug 8, 2023

Ah, I see what's going on -- because this PR only deletes files, DIFF_DOCUMENTS is blank. Feel free to ignore that CI failure for now, I'll follow up and fix this!

@hochan222 hochan222 merged commit e46df3f into mdn:main Aug 8, 2023
@hochan222 hochan222 deleted the ko-delete-untranslated-content-glossary branch August 8, 2023 12:52
@yin1999
Copy link
Member

yin1999 commented Aug 8, 2023

@yin1999, Hello! There seems to be an error in DIFF_DOCUMENTS. Can you check the current issue? https://github.com/mdn/translated-content/blob/main/.github/workflows/pr-check-lint_content.yml (cc. @queengooborg )

image

We could add a if condition just like this. We also need to do this in mdn/content.

if: env.DIFF_DOCUMENTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants