ko: update `Promise.prototype.finally()` to original text #17811

2chanhaeng · 2024-01-09T07:17:11Z

Description

Promise.prototype.finally() 페이지를 원문에 맞춰 업데이트 했습니다.

Motivation

Additional details

Related issues and pull requests

#14965

[Typo error in Promise.prototype.finally() page mdn#14869](mdn#14869) 이슈에서 제안했던 내용에 따라 수정했습니다.

github-actions · 2024-01-09T07:18:56Z

Preview URLs

/ko/docs/Web/JavaScript/Reference/Global_Objects/Promise/finally

Flaws (4)

URL: /ko/docs/Web/JavaScript/Reference/Global_Objects/Promise/finally
Title: Promise.prototype.finally()
Flaw count: 4

macros:
- /ko/docs/Web/JavaScript/Reference/Global_Objects/Promise/catch does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/catch
- /ko/docs/Web/JavaScript/Reference/Global_Objects/Promise/catch does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/catch
- /ko/docs/Web/JavaScript/Reference/Global_Objects/Promise/catch does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/catch
broken_links:
- Can use the English (en-US) link as a fallback

External URLs (1)

URL: /ko/docs/Web/JavaScript/Reference/Global_Objects/Promise/finally
Title: Promise.prototype.finally()

https://github.com/zloirock/core-js (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2024-03-10 22:42:39)

mdn#14965 을 위해 [원문](https://github.com/mdn/content/blob/main/files/en-us/web/javascript/reference/global_objects/promise/finally/index.md)에 맞춰 업데이트 했습니다.

…n-translated-content into ko/promise-finally

files/ko/web/javascript/reference/global_objects/promise/finally/index.md

번역하면서 남겨둔 주석을 지웠습니다.

린터봇의 코멘트 mdn#17811 (comment) 에 따라 일부 헤더를 지웠습니다.

…n-translated-content into ko/promise-finally

2chanhaeng · 2024-01-09T10:20:26Z

#14965 을 위해 원문에 맞춰 업데이트 했습니다.

hochan222

@sunhpark42 3주가 지나 멘션드렸습니다. 확인 한번 부탁드립니다 :)

@2chanhaeng 님, 문서 갱신 표시도 같이 추가하면 좋을듯합니다!

문서 갱신 표시 안내서에 따라 l10n.sourceCommit 추가 부탁드립니다.

files/ko/web/javascript/reference/global_objects/promise/finally/index.md

mdn#17811 (comment)

mdn#17811 (review)

2chanhaeng · 2024-01-29T07:56:15Z

@hochan222 안녕하세요. 리뷰에서 말씀해주신 변경 요청 사항 수정 완료했습니다! 감사합니다.

sunhpark42 · 2024-02-25T08:20:31Z

안녕하세요. 리뷰가 늦어져서 죄송합니다. 명일 2/26일까지 리뷰 드릴 수 있도록 하겠습니다.
기여감사합니다!

sunhpark42

안녕하세요. 리뷰가 늦어졌습니다.
전체 내용중 누락된 부분이 있어서 코멘트 남겨두었습니다. 확인 부탁드립니다.

기여 감사합니다. 🙇‍♀️

files/ko/web/javascript/reference/global_objects/promise/finally/index.md

mdn#17811 (review)

2chanhaeng · 2024-03-01T11:41:45Z

@sunhpark42 안녕하세요. 리뷰에서 말씀해주신 변경 요청 사항 수정 완료했습니다! 감사합니다.

sunhpark42

안녕하세요 @2chanhaeng 님, 수정 해주신 부분 확인 했습니다. 감사합니다 :)
오늘도 좋은하루되세요!

sunhpark42 · 2024-03-17T07:22:39Z

auto-merge 눌러놓겠습니다.
@hochan222 님, Request Change 확인 부탁드립니다. :)

hochan222

모두 고생 많으셨습니다. 좋은 하루 보내세요 :)

* ko: fix error in `Promise.prototype.finally()` [Typo error in Promise.prototype.finally() page mdn#14869](mdn#14869) 이슈에서 제안했던 내용에 따라 수정했습니다. * ko: lint `Promise.prototype.finally()` page * ko: update `Promise.prototype.finally()` to original text mdn#14965 을 위해 [원문](https://github.com/mdn/content/blob/main/files/en-us/web/javascript/reference/global_objects/promise/finally/index.md)에 맞춰 업데이트 했습니다. * ko: remove comment in `Promise.prototype.finally()` 번역하면서 남겨둔 주석을 지웠습니다. * ko: remove headers in `Promise.prototype.finally()` 린터봇의 코멘트 mdn#17811 (comment) 에 따라 일부 헤더를 지웠습니다. * ko: change words to align with the glossary guide mdn#17811 (comment) * ko: add l10n.sourceCommit mdn#17811 (review) * ko: update 'Promise/finally' based on review mdn#17811 (review)

ko: fix error in Promise.prototype.finally()

80f6b55

[Typo error in Promise.prototype.finally() page mdn#14869](mdn#14869) 이슈에서 제안했던 내용에 따라 수정했습니다.

2chanhaeng requested a review from a team as a code owner January 9, 2024 07:17

2chanhaeng requested review from sunhpark42 and removed request for a team January 9, 2024 07:17

github-actions bot added the l10n-ko Issues related to Korean content. label Jan 9, 2024

2chanhaeng and others added 4 commits January 9, 2024 16:32

ko: lint Promise.prototype.finally() page

213e851

Merge branch 'main' into ko/promise-finally

8f339f1

ko: update Promise.prototype.finally() to original text

95ec829

mdn#14965 을 위해 [원문](https://github.com/mdn/content/blob/main/files/en-us/web/javascript/reference/global_objects/promise/finally/index.md)에 맞춰 업데이트 했습니다.

Merge branch 'ko/promise-finally' of https://github.com/2chanhaeng/md…

329f271

…n-translated-content into ko/promise-finally

github-actions bot reviewed Jan 9, 2024

View reviewed changes

files/ko/web/javascript/reference/global_objects/promise/finally/index.md Outdated Show resolved Hide resolved

2chanhaeng and others added 4 commits January 9, 2024 19:13

ko: remove comment in Promise.prototype.finally()

424fae6

번역하면서 남겨둔 주석을 지웠습니다.

Merge branch 'main' into ko/promise-finally

372478d

ko: remove headers in Promise.prototype.finally()

6dba01f

린터봇의 코멘트 mdn#17811 (comment) 에 따라 일부 헤더를 지웠습니다.

Merge branch 'ko/promise-finally' of https://github.com/2chanhaeng/md…

c443254

…n-translated-content into ko/promise-finally

2chanhaeng changed the title ~~ko: fix issue #14869 in Promise.prototype.finally()~~ ko: update Promise.prototype.finally() to original text Jan 9, 2024

hochan222 approved these changes Jan 28, 2024

View reviewed changes

hochan222 requested changes Jan 28, 2024

View reviewed changes

files/ko/web/javascript/reference/global_objects/promise/finally/index.md Outdated Show resolved Hide resolved

2chanhaeng added 3 commits January 29, 2024 16:23

ko: change words to align with the glossary guide

7ac39f9

mdn#17811 (comment)

ko: add l10n.sourceCommit

18155a4

mdn#17811 (review)

Merge branch 'main' into ko/promise-finally

aeff3e9

Merge branch 'main' into ko/promise-finally

51899b6

sunhpark42 requested changes Feb 25, 2024

View reviewed changes

2chanhaeng and others added 3 commits March 1, 2024 19:05

Merge remote-tracking branch 'upstream/main' into ko/promise-finally

87f2d97

ko: update 'Promise/finally' based on review

cd847f2

mdn#17811 (review)

Merge branch 'main' into ko/promise-finally

b22bf68

Merge branch 'main' into ko/promise-finally

556f12b

sunhpark42 approved these changes Mar 17, 2024

View reviewed changes

sunhpark42 enabled auto-merge (squash) March 17, 2024 07:22

hochan222 approved these changes Mar 18, 2024

View reviewed changes

sunhpark42 merged commit 083ffeb into mdn:main Mar 18, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ko: update `Promise.prototype.finally()` to original text #17811

ko: update `Promise.prototype.finally()` to original text #17811

2chanhaeng commented Jan 9, 2024 •

edited

Loading

github-actions bot commented Jan 9, 2024 •

edited

Loading

2chanhaeng commented Jan 9, 2024

hochan222 left a comment

2chanhaeng commented Jan 29, 2024

sunhpark42 commented Feb 25, 2024

sunhpark42 left a comment

2chanhaeng commented Mar 1, 2024

sunhpark42 left a comment

sunhpark42 commented Mar 17, 2024

hochan222 left a comment

ko: update Promise.prototype.finally() to original text #17811

ko: update Promise.prototype.finally() to original text #17811

Conversation

2chanhaeng commented Jan 9, 2024 • edited Loading

Description

Motivation

Additional details

Related issues and pull requests

github-actions bot commented Jan 9, 2024 • edited Loading

2chanhaeng commented Jan 9, 2024

hochan222 left a comment

Choose a reason for hiding this comment

2chanhaeng commented Jan 29, 2024

sunhpark42 commented Feb 25, 2024

sunhpark42 left a comment

Choose a reason for hiding this comment

2chanhaeng commented Mar 1, 2024

sunhpark42 left a comment

Choose a reason for hiding this comment

sunhpark42 commented Mar 17, 2024

hochan222 left a comment

Choose a reason for hiding this comment

ko: update `Promise.prototype.finally()` to original text #17811

ko: update `Promise.prototype.finally()` to original text #17811

2chanhaeng commented Jan 9, 2024 •

edited

Loading

github-actions bot commented Jan 9, 2024 •

edited

Loading