Update the commands sample to have 2 commands
#491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the change, the sample showed how to add one command, and how to update it, reset it, and respond to it. But usually the extension developer needs to configure more than one command, and the code was not readily usable for such a need. After this patch, the developer can easily see what are the different places they need to make conditional decisions, to add a new command to the extension. This patch also includes some cosmetic changes, like wrapping the long lines of the README.md, as intended by the authors of Markdown syntax. If desirable, I can put such cosmetic changes in a separate commit.
github-actions
bot
added
the
idle
github-actions
bot
removed
the
idle
|
@gurjeet I've tested the update, and this extension no longer seems to work as expected, it doesn't pre-populate the existing value for shortcut one, and I am not able to register any new keyboard shortcuts. Could you also explain why you added the description fields? Also, please revert the changes to the readme file, there's no need to manually apply line wraps. |
github-actions
bot
added
the
idle
|
This PR has been inactive for over a year. While the change may be helpful, there are issues in the code and further improvements are needed to achieve the intended goal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
commandssample to have 2 commandsBefore the change, the sample showed how to add one command, and how to
update it, reset it, and respond to it. But usually the extension
developer needs to configure more than one command, and the code was not
readily usable for such a need.
After this patch, the developer can easily see what are the different
places they need to make conditional decisions, to add a new command to
the extension.
This patch also includes some cosmetic changes, like wrapping the long
lines of the README.md, as intended by the authors of Markdown syntax.
If desirable, I can put such cosmetic changes in a separate commit.