Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign CI for extensions. #531

Closed
wants to merge 2 commits into from
Closed

Sign CI for extensions. #531

wants to merge 2 commits into from

Conversation

uiolee
Copy link
Contributor

@uiolee uiolee commented Jul 7, 2023

Description

Hi there.
I wrote a script for signing extensions. It depends on Github Action. And requires AMO account API

Motivation

Provides an easier way to install the examples.

Additional details

Procedure

  1. Detect whether the manifest changes every time you commit.
  2. try to Sign by sign-addon.
  3. publish to Github Release.

How to test

  1. fork and clone this branch
  2. set secrets.
  3. change extensions version.
  4. push to main or sign branch

Doubt

Whether the ID should be saved to the repository

if not:

  • It takes longer to wait for each signing.
  • You will see multiple duplicates of the same extension in your AMO account.
  • version can be the same.

Related issues and pull requests

#397

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@Rob--W
Copy link
Member

Rob--W commented Jul 11, 2023

The Github actions in this repo are meant to support the maintenance of extension examples. The proposed signing action does not fit in this repository.

@Rob--W Rob--W closed this Jul 11, 2023
@uiolee
Copy link
Contributor Author

uiolee commented Jul 11, 2023

Then maybe we should remove those built version in /build

@Rob--W
Copy link
Member

Rob--W commented Jul 11, 2023

Then maybe we should remove those built version in /build

We probably should. We should check whether anything references it and if not just delete it.

@rebloor
Copy link
Collaborator

rebloor commented Jul 12, 2023

See Remove built extensions #397.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants