Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bcd): make BCD table's header sticky #8541

Closed
wants to merge 15 commits into from
Closed

feat(bcd): make BCD table's header sticky #8541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
96e64b8
Add `overflow: hidden` to `.bc-table`
yarusome Mar 31, 2023
b8df4f5
Make `.bc-table thead` sticky
yarusome Mar 31, 2023
ab700fe
Revert changes to `index-desktop.scss`
yarusome Apr 6, 2023
2e1f4c5
Make BCD table sticky for `screen-md` and above
yarusome Apr 6, 2023
a9e27e9
Fix linting
yarusome Apr 6, 2023
d65d236
Fix linting
yarusome Apr 6, 2023
4da1d38
Fix linting
yarusome Apr 6, 2023
b211d13
Revert changes to `index.scss`
yarusome Apr 6, 2023
cd064ee
Merge branch 'mdn:main' into sticky-bcd-table
yarusome Apr 16, 2023
522a846
Remove unused block
yarusome Apr 16, 2023
cf41775
Sticky BCD table - version 3
yarusome Apr 16, 2023
50f29be
Relocate margin
yarusome Apr 16, 2023
f1f4183
Linting
yarusome Apr 16, 2023
2ac8050
Simplify nesting
yarusome Apr 16, 2023
6c51365
add bc-table-container class
LeoMcA May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions client/src/document/ingredients/browser-compatibility-table/index-desktop-md.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,76 @@
width: calc(100% + 6rem);
}

.bc-table-container {
margin: 1rem -3rem 0;
max-height: calc(100vh - var(--main-document-header-height) - 8rem);
}

.bc-table {
border: none;
margin: 0 0 1rem;

tbody tr {
td:last-child {
border-right: 1px solid var(--border-primary);
}

th {
border-left: 1px solid var(--border-primary);
}

&:last-child {
td {
border-bottom-color: var(--border-primary);

&:last-child {
border-bottom-right-radius: var(--elem-radius);
}
}

th {
border-bottom-color: var(--border-primary);
border-bottom-left-radius: var(--elem-radius);
}
}
}

thead {
background-color: var(--background-primary);
position: sticky;
top: 0;
z-index: var(--z-index-low);
}

tbody th {
width: 20%;
}
}

.bc-browsers {
td {
border-left: 1px solid var(--border-primary);
}

th:last-child {
border-right: 1px solid var(--border-primary);
}
}

.bc-platforms {
td {
border-left: 1px solid var(--border-primary);
border-top: 1px solid var(--border-primary);
border-top-left-radius: var(--elem-radius);
}

th {
border-top: 1px solid var(--border-primary);

&:last-child {
border-right: 1px solid var(--border-primary);
border-top-right-radius: var(--elem-radius);
}
}
}
}
4 changes: 4 additions & 0 deletions client/src/document/ingredients/browser-compatibility-table/index-desktop-xl.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
width: 100%;
}

.bc-table-container {
margin: 1rem 0 0;
}

.table-container-inner {
padding: 0;
}
Expand Down
9 changes: 0 additions & 9 deletions client/src/document/ingredients/browser-compatibility-table/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,6 @@
tr {
height: 3rem;

@media screen and (min-width: $screen-md) {
&:last-child {
th,
td {
border-bottom-width: 0;
}
}
}

th {
border-left-width: 0;
vertical-align: middle;
Expand Down
2 changes: 1 addition & 1 deletion client/src/document/ingredients/browser-compatibility-table/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ export default function BrowserCompatibilityTable({
>
Report problems with this compatibility data on GitHub
</a>
<figure className="table-container">
<figure className="table-container bc-table-container">
<figure className="table-container-inner">
<table key="bc-table" className="bc-table bc-table-web">
<Headers
Expand Down